GNOME Bugzilla – Bug 749722
Totem writes to gsettings on startup
Last modified: 2018-05-24 11:04:22 UTC
Totem writes to the active-plugins key multiple times on startup, once for each builtin plugin that is not listed in the default for that key. Changing the default to include all plugins would solve this. That means that we'd need to take care to always update the default. Also, when we ever turn a builtin plugin off by default in the future, it will still be enabled for people that used that upgraded from an older version ("active-plugins" will still contain the plugin). I think not listing builtin plugins in that key makes the most sense. The attached patch does that. Peas doesn't provide a list of loaded plugins that are not builtin, so this patch needs to merge/filter the list when writing/reading the key. I'll open a bug against peas as well.
Created attachment 303813 [details] [review] Don't save builtin plugins to gsettings Builtin plugins are not meant to be disabled by users and are thus not part of user settings. Do this by filtering out builtin plugins before writing and inserting them when reading from the settings key. This also stops Totem from writing to gsettings on startup. The list of builtin plugins was not in sync with the default value of the active-plugins gsettings key.
Filed for peas at bug #749724.
I changed the description a tad, and committed. Thanks!
Turns out this was utterly broken. If you run: gsettings reset org.gnome.totem active-plugins You'll end with none of the builtin plugins being loaded, and if you force load them, they'll get unloaded. I couldn't figure out what the problem is, so reverted that patch, as we're really close to release. (FWIW, I saw this problem after trying to write a new plugin, which didn't work. Turns out my plugin was instantly unloaded) commit 54215692596b3187bbed5d4aa52f9bf9395629b0 Author: Bastien Nocera <hadess@hadess.net> Date: Fri Mar 11 20:03:07 2016 +0100 Revert "plugins: Don't save builtin plugins to GSettings" This reverts commit f0c645c7c33867be239a0f637909fa8314e53d92. It caused builtin plugins not to get loaded. See https://bugzilla.gnome.org/show_bug.cgi?id=749722
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/totem/issues/145.