After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749717 - wayland: Position popups relative to the parent surface
wayland: Position popups relative to the parent surface
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on: 749716
Blocks:
 
 
Reported: 2015-05-22 08:43 UTC by Jonas Ådahl
Modified: 2015-06-10 03:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Position popups relative to the parent surface (1.32 KB, patch)
2015-05-22 08:43 UTC, Jonas Ådahl 		committed Details | Review

Description Jonas Ådahl 2015-05-22 08:43:38 UTC 
This patch fixes the popup position so that it conforms to the protocol specification. It also makes menus work better under weston.

I recommend waiting with pushing this patch until the corresponding mutter patch is ready to be pushed. The mutter bug is https://bugzilla.gnome.org/show_bug.cgi?id=749716 .
Comment 1 Jonas Ådahl 2015-05-22 08:43:43 UTC 
Created attachment 303801 [details] [review]
wayland: Position popups relative to the parent surface

According to the xdg-shell protocol specification the (x, y) coordinates
passed when creating a popup surface is relative to top left corner of
the parent surface, but prior to this patch, if the parent surface
was an xdg_surface, we'd position it relative to top left corner of the
window geometry of that xdg_surface.
Comment 2 Matthias Clasen 2015-05-29 03:22:07 UTC 
Review of attachment 303801 [details] [review]:

I don't know the protocol in that level of detail, but if you say so...
Comment 3 Matthias Clasen 2015-05-29 03:22:21 UTC 
Review of attachment 303801 [details] [review]:

I don't know the protocol in that level of detail, but if you say so...
Comment 4 Jonas Ådahl 2015-06-10 03:09:14 UTC 
Attachment 303801 [details] pushed as 0f47d1b - wayland: Position popups relative to the parent surface