After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 749716 - xdg-shell: Popups should be placed relative to the parent surface
xdg-shell: Popups should be placed relative to the parent surface
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks: 749717
 
 
Reported: 2015-05-22 08:39 UTC by Jonas Ådahl
Modified: 2015-06-10 03:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
xdg-shell: Popups should be placed relative to the parent surface (1.37 KB, patch)
2015-05-22 08:39 UTC, Jonas Ådahl
committed Details | Review

Description Jonas Ådahl 2015-05-22 08:39:14 UTC
This patch depends on https://bugzilla.gnome.org/show_bug.cgi?id=744934 .
Comment 1 Jonas Ådahl 2015-05-22 08:39:19 UTC
Created attachment 303800 [details] [review]
xdg-shell: Popups should be placed relative to the parent surface

According to the xdg-shell protocol specification the (x, y) coordinates
passed when creating a popup surface is relative to top left corner of
the parent surface, but prior to this patch, if the parent surface was
a xdg_surface, it'd position it relative to top left corner of the
window geometry of that xdg_surface.
Comment 2 Jasper St. Pierre (not reading bugmail) 2015-06-10 02:45:17 UTC
Review of attachment 303800 [details] [review]:

Nice catch, thanks.
Comment 3 Jonas Ådahl 2015-06-10 03:09:02 UTC
Attachment 303800 [details] pushed as daa15d9 - xdg-shell: Popups should be placed relative to the parent surface