GNOME Bugzilla – Bug 748176
out-of-tree distcheck fails in build/win32
Last modified: 2015-04-20 14:54:51 UTC
Created attachment 301982 [details] [review] Makefile-newvs: some .vcxproj.filters files are in builddir, some in srcdir Without this change, out-of-tree distcheck doesn't get very far. --- Regression in commit 68bb63e3, I think.
Review of attachment 301982 [details] [review]: Hi Simon, I see, thanks for letting me know this... However, the ones that process the property sheets (%.props) and the projects (%.vcxproj) will also need to be updated as well, because by the same logic they can be either generated in $(top_buildir) or is already in $(top_srcdir), and this script is to be used in components of the GTK+ stack. Can I know whether the old version before the said commit working before this commit when buildir != srcdir? Thanks though, with blessings!
(In reply to Fan, Chun-wei from comment #1) > Can I know whether the old version before the said commit working before > this commit when buildir != srcdir? Commit 6a254344 (immediately before the change I mentioned) fails with Bug #748177, but I think that's quite a long time after it would have failed with this bug. Re-testing now with my patch for #748177 applied on top of 6a254344. (In reply to Fan, Chun-wei from comment #1) > However, the ones that process the property sheets (%.props) and the > projects (%.vcxproj) will also need to be updated as well I can add that to the patch if you want, but it'd be "blind", because I'm currently only testing GLib, and not other components into which the same file might have been pasted.
(In reply to Simon McVittie from comment #2) > Re-testing now with my patch for #748177 applied on top of > 6a254344. That worked. So, yes, it looks like this was a regression in 6a254344.
Created attachment 301996 [details] [review] Makefile-newvs: some .vcxproj.filters files are in builddir, some in srcdir Without this change, out-of-tree distcheck doesn't get very far. Similarly, allow *.vcxproj, *.props to be in either the builddir or the srcdir. Finally, since I'm touching these lines anyway, eliminate some useless uses of cat: "cat x | sed 's/foo/bar/' > y" is equivalent to "sed 's/foo/bar/' < x > y". --- Still running distcheck on this one, but I think it's already got further than it would have done if the bug was still present.
Hi Simon, (In reply to Simon McVittie from comment #3) > That worked. So, yes, it looks like this was a regression in 6a254344. I see, sorry. One of the main reasons for my coomit was to fix a make -jN distcheck issue though. As the one who came up with this file, I'd say it looks good to me. Please go ahead to push this, I am likely going to push your patch into at least ATK, GDK-Pixbuf and GTK+, to let you know. With blessings, thank you!
Review of attachment 301996 [details] [review]: .
(In reply to Simon McVittie from comment #4) > Still running distcheck on this one, but I think it's already got further > than it would have done if the bug was still present. Seems to work. > Finally, since I'm touching these lines anyway, eliminate some > useless uses of cat: "cat x | sed 's/foo/bar/' > y" is > equivalent to "sed 's/foo/bar/' < x > y". Relevant: https://en.wikipedia.org/wiki/Cat_%28Unix%29#Useless_use_of_cat Irrelevant: https://imgflip.com/i/kexy7
Comment on attachment 301996 [details] [review] Makefile-newvs: some .vcxproj.filters files are in builddir, some in srcdir Committed as 9bc3ae9 for 2.45.0