GNOME Bugzilla – Bug 747729
Update UI styles to be closer to gtk+ 3.16
Last modified: 2015-04-22 09:46:59 UTC
Created attachment 301400 [details] Screenshot (Better UI) Evolution UI looks bad in recent versions of GNOME. I tweaked it a bit to look better. However, i think we need do more to improve UI. Many custom widgets is ugly and able replaced by new gtk+ widgets.
Created attachment 301401 [details] [review] Add-linked-style-class-for-ECanvas-header
Created attachment 301402 [details] [review] Remove-shadow-in-scrolled-windows
Created attachment 301403 [details] [review] Add-top-and-bottom-content-separators
Created attachment 301404 [details] [review] Remove-override-background-color-in-eventbox
Created attachment 301405 [details] [review] Add-miss-top-padding-in-switcher-buttons-layout
Created attachment 301406 [details] [review] Add-margin-to-calendar-widget-in-sidebar
Thanks for the patches!
Thanks for a bug report and patches. Could you capture a screenshot without those patches applied, please? I do not see much difference, except of the icons in the header bar being aligned to the right, while they should be in the center.
Created attachment 301608 [details] Screenshot (without patches)
*** Bug 747799 has been marked as a duplicate of this bug. ***
Thanks for the screenshot. I just noticed that bug #747799 has the screen shot too. If I see the differences right, and they are mostly tiny from my point of view: a) toolbar has a bottom horizontal line * I'm fine with this b) added bigger vertical gap in the search bar line * I'm not a fan of bigger gaps, we also aim small screens where each pixel counts c) removed lines around the folder tree * It makes it look awkward (without border, not separated from the surrounding darker widgets) d) not much space for dividers/sliders between the folder tree and between the message list and the message preview * The way gtk begun to "render" sliders is awful from my point of view, because there is absolutely no indication that a user can actually slide anything there - "either you know or you are doomed" rule doesn't work e) status bar has a top horizontal line, which divides it from the switcher buttons at the bottom * I would not add that line there, the division between the two is not necessary f) the header icons has the aforementioned horizontal offset * the bug #747799 is about it, let's deal with it here
b) Sorry, that screenshot is outdate :) c) I will add it. d) We can set wide-handle property but requiring Gtk+ 3.16. Other way, get -GtkPaned-handle-size value from theme and apply custom css. e) I think it's nice on Adwaita.
Created attachment 301615 [details] Screenshot (with wide handle)
Created attachment 301751 [details] unidentifiable columns in Task view About icons, the 'Type' and 'Completed' columns in the Task view don't have anything (an icon for example) to make them easy to identify on the spot.
Created attachment 301752 [details] unidentifiable column in Memos view The 'Type' column in the Memos view is also identifiable at sight.
(In reply to Luis Henrique Mello from comment #14) > Created attachment 301751 [details] > unidentifiable columns in Task view > > About icons, the 'Type' and 'Completed' columns in the Task view don't have > anything (an icon for example) to make them easy to identify on the spot. (In reply to Luis Henrique Mello from comment #15) > Created attachment 301752 [details] > unidentifiable column in Memos view > > The 'Type' column in the Memos view is also identifiable at sight. The both is a regression either from gtk+ itself or by the styling, because I see there those icons with gtk3 3.14.6, but not with gtk3 3.16.0. I also believe it's related to this: (In reply to Milan Crha from comment #11) > f) the header icons has the aforementioned horizontal offset > * the bug #747799 is about it, let's deal with it here
Trinh, could you merge all your patches into one, add the fix for header icons and upload it here for review, please? (In reply to Trinh Anh Ngoc from comment #13) > Created attachment 301615 [details] > Screenshot (with wide handle) Those handle lines look odd, especially at the left-center place where the horizontal slider is connected to the vertical slider. It's not that visible with the older (3.14.6) gtk, because the slider was a dark space, not a space with up/bottom or left/right border lines and a light background. I do not think it's a good idea to overwrite the style in the code much, because: a) tweaking for one theme may break any other themes; b) diverging from the theme settings might change user's experience, different look and feel than other applications, which is slightly against your initiative here. In other words, it's hard to find a good consensus. If the default gtk+ theme forces 0-width sliders, then there is basically nothing we can do about it (which is the meaning of my rant at the comment #11, it wasn't that much about your change, but about the theme change).
Created attachment 302086 [details] [review] Improve UI on GNOME 3.16
Thanks for the update. The patch introduces one compiler warning: e-shell-sidebar.c: In function 'e_shell_sidebar_init': e-shell-sidebar.c:438:10: warning: unused variable 'bg' [-Wunused-variable] GdkRGBA bg; ^ which I fixed before committing. Created commit 2702cc0 in evo master (3.17.1+) Created commit beca851 in evo gnome-3-16 (3.16.2+)
I opened bug #748285, because the above change doesn't address that part. Trinh, I'd appreciate if you could look on it. Thanks in advance.