After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746539 - ovirt-proxy: Do not handle REST_PROXY_ERROR_CANCELLED as error
ovirt-proxy: Do not handle REST_PROXY_ERROR_CANCELLED as error
Status: RESOLVED FIXED
Product: libgovirt
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libgovirt maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-03-20 16:46 UTC by Pavel Grunt
Modified: 2015-04-08 14:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ovirt-proxy: Do not handle REST_PROXY_ERROR_CANCELLED as error (2.21 KB, patch)
2015-03-20 16:46 UTC, Pavel Grunt 		committed Details | Review

Description Pavel Grunt 2015-03-20 16:46:24 UTC 
Created attachment 299965 [details] [review]
ovirt-proxy: Do not handle  REST_PROXY_ERROR_CANCELLED as error

Do not warn in that case, set OVIRT_REST_CALL_ERROR_CANCELLED instead.

This patch introduces new GError OVIRT_REST_CALL_ERROR_CANCELLED. It can be used for informing that processing of a rest call was cancelled and should not be treated as an error.

The example of a call that can be cancelled is the authentication: https://bugzilla.gnome.org/show_bug.cgi?id=746537
Comment 1 Christophe Fergeau 2015-03-25 14:20:18 UTC 
Review of attachment 299965 [details] [review]:

Looks good.