After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746537 - Add rest_proxy_auth_cancel for cancelling authentication
Add rest_proxy_auth_cancel for cancelling authentication
Status: RESOLVED FIXED
Product: librest
Classification: Platform
Component: proxy
git master
Other Linux
: Normal normal
: ---
Assigned To: librest-maint
librest-maint
Depends on:
Blocks:
 
 
Reported: 2015-03-20 16:28 UTC by Pavel Grunt
Modified: 2015-04-08 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rest-proxy-auth: Add rest_proxy_auth_cancel for cancelling authentication (1.55 KB, patch)
2015-03-20 16:28 UTC, Pavel Grunt
none Details | Review
rest-proxy-auth: Add rest_proxy_auth_cancel for cancelling authentication (1.75 KB, patch)
2015-03-25 15:14 UTC, Pavel Grunt
committed Details | Review

Description Pavel Grunt 2015-03-20 16:28:36 UTC
Created attachment 299959 [details] [review]
rest-proxy-auth: Add rest_proxy_auth_cancel for cancelling authentication

It can be helpful when handling the "authenticate" signal to allow to cancel the authentication instead of failing with an error.
Comment 1 Christophe Fergeau 2015-03-25 14:26:11 UTC
Review of attachment 299959 [details] [review]:

Looks good, doc could be a bit more detailed.

::: rest/rest-proxy-auth.c
@@ +140,3 @@
+ * @auth: a paused #RestProxyAuth
+ *
+ * Cancel message processing

Can you detail a bit more what will happen when this is called? (auth will be cancelled, and a _CANCELLED error will be returned to the calling function).
Comment 2 Pavel Grunt 2015-03-25 15:14:25 UTC
Created attachment 300286 [details] [review]
rest-proxy-auth: Add rest_proxy_auth_cancel for cancelling authentication

It can be helpful when handling the "authenticate" signal to allow
to cancel the authentication instead of failing with an error.
---
v2: more detailed doc

/**
 * rest_proxy_auth_cancel:
 * @auth: a #RestProxyAuth
 *
 * Cancel the authentication process
 * by cancelling the associated #SoupMessage.
 * It results in returning #GError REST_PROXY_ERROR_CANCELLED
 * to the function that requested the authentication.
 */