GNOME Bugzilla – Bug 746537
Add rest_proxy_auth_cancel for cancelling authentication
Last modified: 2015-04-08 15:04:32 UTC
Created attachment 299959 [details] [review] rest-proxy-auth: Add rest_proxy_auth_cancel for cancelling authentication It can be helpful when handling the "authenticate" signal to allow to cancel the authentication instead of failing with an error.
Review of attachment 299959 [details] [review]: Looks good, doc could be a bit more detailed. ::: rest/rest-proxy-auth.c @@ +140,3 @@ + * @auth: a paused #RestProxyAuth + * + * Cancel message processing Can you detail a bit more what will happen when this is called? (auth will be cancelled, and a _CANCELLED error will be returned to the calling function).
Created attachment 300286 [details] [review] rest-proxy-auth: Add rest_proxy_auth_cancel for cancelling authentication It can be helpful when handling the "authenticate" signal to allow to cancel the authentication instead of failing with an error. --- v2: more detailed doc /** * rest_proxy_auth_cancel: * @auth: a #RestProxyAuth * * Cancel the authentication process * by cancelling the associated #SoupMessage. * It results in returning #GError REST_PROXY_ERROR_CANCELLED * to the function that requested the authentication. */