After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746220 - MessageTray: collapse notification after they're hidden
MessageTray: collapse notification after they're hidden
Status: RESOLVED OBSOLETE
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 744948 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-03-14 22:28 UTC by Giovanni Campagna
Modified: 2015-03-17 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
MessageTray: collapse notification after they're hidden (1.36 KB, patch)
2015-03-14 22:28 UTC, Giovanni Campagna
none Details | Review

Description Giovanni Campagna 2015-03-14 22:28:43 UTC
This is necessary to fix chat notifications: otherwise, updates
to chat notifications see .expanded == true in .update(), therefore
they cause a new .expand() which reemits 'expanded' and causes
the telepathy code to ack the messages too soon, which then
results in no notification at all.
Comment 1 Giovanni Campagna 2015-03-14 22:28:47 UTC
Created attachment 299420 [details] [review]
MessageTray: collapse notification after they're hidden
Comment 2 Florian Müllner 2015-03-14 22:33:47 UTC
I would still prefer to move chat notifications to the "new" banners for 3.16, but if we don't get that in, this patch should fix bug 744948 ...
Comment 3 Florian Müllner 2015-03-14 22:35:12 UTC
*** Bug 744948 has been marked as a duplicate of this bug. ***
Comment 4 Florian Müllner 2015-03-17 15:14:12 UTC
(In reply to Florian Müllner from comment #2)
> I would still prefer to move chat notifications to the "new" banners for
> 3.16

This happened in bug 746343.