GNOME Bugzilla – Bug 745945
In files application dialog Orca doesn't presenting right some toggle button descriptions
Last modified: 2015-03-10 15:00:46 UTC
Created attachment 298948 [details] Debug file with possible showing why happening this issue Dear Joanie, In Files application window Orca doesn't speaking and presents braille right some toggle buttons description with non english locales. In end of where am I command result all toggle buttons I hear right description if I using hungarian locale. Testcase: 1. Launch files application when you using non english locale. 2. Go back the Close button with SHIFT+TAB key combination. 3. Use SHIFT+TAB keystroke to jump the toggle buttons. Expected result if this is possible: Orca need announce human readable toggle button descriptions, this is not always right happening. A typical example the "down" label announced toggle button, with provide possibility to set the layout mode and view layout. Any toggle buttons in the Files application dialog when I doing where am I command, end of where am I output I always hear right the localized descriptions. With braille related more time good the toggle button descriptions, but the "down" announced toggle button description is not good. Toggle buttons related with src/orca/formatting.py file Orca using following formatting values the pyatspi.Role_TOGGLE_BUTTON: 1. Speech related: 'focused': 'expandableState or toggleState', 'unfocused': 'labelOrName + roleName + (expandableState or toggleState) + availability + ' + MNEMONIC + ' + accelerator', 'basicWhereAmI': 'labelOrName + roleName + (expandableState or toggleState)' 2. Braille: 'unfocused': '[Component(obj,\ asString((labelOrName or description) + expandableState + roleName),\ indicator=asString(toggleState))]' If my local system I modifyed the Toggle buttons related formatting values, I hear always right the localized descriptions. I used following modifications: 'focused': 'expandableState or toggleState', 'unfocused': '(label or description or name) + accelerator + roleName + (expandableState or toggleState) + availability + ' + MNEMONIC + ' + accelerator', 'basicWhereAmI': '(label or description or name) + roleName + (expandableState or toggleState)' My environment related informations: OS: Ubuntu 14.04.2 Files application version: 3.10.x series Orca version: 3.14.3 (gnome-3-14 branch version) Affected Orca branches: master, gnome-3-14, gnome-3-16 I attaching a debug.out file. Attila
Created attachment 298949 [details] Video with buggy announced toggle buttons related Joanie, I created a video to you easyer see now what happening in Files applications dialog. I simple doing I wrote testcase in Files applications dialog. When the focus lands a toggle button, the first output shows Orca normal speaking an english locale, the second output shows the where am I output. With english locale clear seeing too Orca simple skyp announce some toggle buttons description announce. With "down" toggle button related: I think this toggle button the "name" property get the down text, and the localized description is stored the description formatting property. I not understanding only one thing: end of where am I output why always presenting right the toggle button description? Attila
Created attachment 298950 [details] Video the possible fix related Joanie, this video shows my local system applied fix result with I described in first comment. If I applying the described fix, all toggle button descriptions right announce Orca in Files applications related. If I using non english locale, I hear right the translated descriptions. Because the zip compressed video is not fitted in Bugzilla limit, I compressed the video witr. You need installing the unrar package if not installed your system. Attila
Created attachment 298952 [details] [review] Possible solution related patch Joanie, please review this fix method. If you have better ydea to we get equals good result with shows the second attached video, please tell me. Now, speech and braille me producing equals good result in Files application window. Attila
Thanks Attila! I'm afraid, however, the problem with your patch is twofold: 1. It will change the behavior for all applications of properly-named toggle buttons which also have descriptions which might not be very good, or too long, or something else that makes the name preferable. 2. It won't solve anything in the new version of Nautilus. I just tested there and the buttons have useless names and no descriptions. The descriptions in earlier versions probably came from tooltips. Regardless.... What's called for is proper names. The accessible name is *the* thing a screen reader should present when a widget gains focus. And the correct place to fix bugs like "application foo does not have good names for their widgets" is in application foo. I've just opened a bug against Nautilus: https://bugzilla.gnome.org/show_bug.cgi?id=745967 *** This bug has been marked as a duplicate of bug 745967 ***
Hi Joanie, Many thanks the Nautilus report, hopefuly Nautilus developers fixing this issue the 3.16 version any time and future will not have problem this in Files application. Attila