After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 745843 - Seahorse should support GnuPG 2.1
Seahorse should support GnuPG 2.1
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on: 742094
Blocks:
 
 
Reported: 2015-03-08 15:28 UTC by Hristo Venev
Modified: 2015-11-18 11:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (232 bytes, patch)
2015-04-22 20:48 UTC, Hristo Venev 		none Details | Review
allow building with gnupg 2.1 (699 bytes, patch)
2015-10-17 06:57 UTC, Antoine Jacoutot 		accepted-commit_now Details | Review

Description Hristo Venev 2015-03-08 15:28:56 UTC 
--- a/configure.ac
+++ b/configure.ac
@@ -9,7 +9,7 @@
 GTK_REQ=3.4.0
 GTK_MAX=GTK_VERSION_3_4
 
-GNUPG_ACCEPTED="1.2 1.4 2.0"
+GNUPG_ACCEPTED="1.2 1.4 2.0 2.1"
 GPGME_REQUIRED=1.0.0
 LIBSECRET_REQUIRED=0.16
 AVAHI_GLIB_REQUIRED=0.6

It seems to work OK.
Comment 1 Luis Henrique Mello 2015-04-22 17:26:20 UTC 
(In reply to Hristo Venev from comment #0)
> --- a/configure.ac
> +++ b/configure.ac
> @@ -9,7 +9,7 @@
>  GTK_REQ=3.4.0
>  GTK_MAX=GTK_VERSION_3_4
>  
> -GNUPG_ACCEPTED="1.2 1.4 2.0"
> +GNUPG_ACCEPTED="1.2 1.4 2.0 2.1"
>  GPGME_REQUIRED=1.0.0
>  LIBSECRET_REQUIRED=0.16
>  AVAHI_GLIB_REQUIRED=0.6
> 
> It seems to work OK.

Hi Hristo, I think you should post this patch as an attachment for future review by the developers
Comment 2 Hristo Venev 2015-04-22 20:48:22 UTC 
Created attachment 302183 [details] [review]
Patch

OK, here it is as an attachment.
Comment 3 Stef Walter 2015-04-23 05:51:14 UTC 
This can't be fixed until bug #742094 is fixed.
Comment 4 Pacho Ramos 2015-06-14 18:57:33 UTC 
Looks like the way it will be fixed in gnome-keyring daemon is dropping its gpg-agent... then, I am not what should we do on seahorse (and libgcryptui that is also affected by this) side :/

Thanks for your help
Comment 5 Pacho Ramos 2015-06-14 18:58:46 UTC 
libcryptui I meant
Comment 6 Pacho Ramos 2015-06-22 13:19:15 UTC 
I guess this is fixed for seahorse with bug 750468... but libcryptui is still affected by this (it looks like it doesn't have its own bugzilla component apart of seahorse one yet :/)
Comment 7 Antoine Jacoutot 2015-10-17 06:57:21 UTC 
Created attachment 313513 [details] [review]
allow building with gnupg 2.1

Trivial patch to allow building with gnupg 2.1. OK to push?
Comment 8 Stef Walter 2015-10-17 08:03:27 UTC 
Review of attachment 313513 [details] [review]:

Assuming you've tested this, looks good to me.
Comment 9 Antoine Jacoutot 2015-10-17 08:09:19 UTC 
(In reply to Stef Walter from comment #8)
> Review of attachment 313513 [details] [review] [review]:
> 
> Assuming you've tested this, looks good to me.

Yup I did (we were using the same patch in OpenBSD ports).
Thanks, it's in: 183d7619
Comment 10 Antoine Jacoutot 2015-11-18 11:11:10 UTC 
I think this Bug could be closed now.