After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 750468 - please build seahorse to work with any maintained version of gpg
please build seahorse to work with any maintained version of gpg
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2015-06-05 20:38 UTC by Daniel Kahn Gillmor
Modified: 2017-04-02 15:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
update seahorse build practice to work against any maintained branch of gnupg (5.81 KB, patch)
2015-06-05 20:38 UTC, Daniel Kahn Gillmor
none Details | Review

Description Daniel Kahn Gillmor 2015-06-05 20:38:03 UTC
Created attachment 304672 [details] [review]
update seahorse build practice to work against any maintained branch of gnupg

seahorse currently detects the version of gpg on the system it is built on.  It embeds the path  and behaves differently depending on the version it was built against instead of the version it is running with.

It also explicitly specifies the name of the executable to libgpgme; but libgpgme is smart enough to pick the right one (it probably knows better at runtime than seahorse does at compiletime).

Also, GnuPG upstream hasn't supported 1.2.x for years.

The attached patch makes seahorse much less dependent on the version of GnuPG running on the build system.
Comment 1 Stef Walter 2015-06-09 05:54:41 UTC
In general this patch looks good. I'd like to go a step further.

As I understand it, the current work on the pinentry-gnome3 will mean GNOME will no longer really have integrated support for gnupg 1.4 out of the box. Since gnupg 1.4.x didn't start its own gpg-agent, and gnome-keyring will no longer start one, the user will largely on their own when it comes to gnupg 1.4.x ... at least without assistance from GNOME.

So we should probably just drop support for 1.4.x in seahorse as well.

I have very little time to dedicate to work on seahorse, so simplifying the compatibility matrix makes things more realistic ...

Although I personally have had problems using GnuPG 2.x that I'm still trying to figure out how to resolve ... I think the right approach is moving forward to make 2.x usable rather than remaining tied to 1.x forever.
Comment 2 Daniel Kahn Gillmor 2015-06-09 20:39:23 UTC
I'm fine with dropping support for 1.4.x explicitly if you want seahorse to do that.  In debian, the gnupg-agent package (before 2.1) actually self-initializes during the X11 session (see `/etc/X11/Xsession.d/90gpg-agent`).  It does this without assistance from GNOME.
Comment 3 Daniel Kahn Gillmor 2015-06-09 20:44:05 UTC
(In reply to Stef Walter from comment #1)

> Although I personally have had problems using GnuPG 2.x that I'm still
> trying to figure out how to resolve ...

(aside: Stef, if you're having problems, please feel free to file bugs at https://bugs.gnupg.org/, or raise them at 
https://lists.gnupg.org/mailman/listinfo/gnupg-users, we'd be happy to help resolve them)
Comment 4 Stef Walter 2015-06-10 06:51:00 UTC
(In reply to Daniel Gillmor from comment #3)
> (aside: Stef, if you're having problems, please feel free to file bugs at ...

Thanks. I got help on IRC. My keys had subkeys that gnupg 1.x would ignore, but caused gnupg 2.x to have a fit. Removing those subkeys and I was back to normal.
Comment 5 Stef Walter 2015-06-12 10:40:35 UTC
Thanks Daniel. Modified the patch slightly based on what we discussed
above (no GnuPG 1.x support) ... and pushed to git master.