GNOME Bugzilla – Bug 745301
gnome-settings-daemon: support WM settings overrides for GNOME Flashback
Last modified: 2016-01-04 13:16:53 UTC
In the GNOME Flashback environment, like in Classic, we want a more traditional button layout for the WM. Please consider the following patch for git master to support settings overrides for Flashback in a similar way to how Classic's overrides are handled.
Created attachment 298115 [details] [review] Patch for git master
Review of attachment 298115 [details] [review]: Pretty sure I've already mentioned to your colleagues working on GNOME Flashback that they should fork their own settings-daemon. I really don't want to have this in gnome-settings-daemon, handling the dual-settings is already a pain, and I don't want to add another layer on top of that.
(In reply to Bastien Nocera from comment #2) > I really don't want to have this in gnome-settings-daemon, handling the > dual-settings is already a pain, and I don't want to add another layer on > top of that. Flashback has the same issue as Classic in that we too want to override the WM style to be more traditional. Therefore, does it not make sense to address the issue in the same code and in the same fashion?
(In reply to Yaakov Selkowitz from comment #3) > (In reply to Bastien Nocera from comment #2) > > I really don't want to have this in gnome-settings-daemon, handling the > > dual-settings is already a pain, and I don't want to add another layer on > > top of that. > > Flashback has the same issue as Classic in that we too want to override the > WM style to be more traditional. Therefore, does it not make sense to > address the issue in the same code and in the same fashion? There are already plenty of things in gnome-settings-daemon which will break when using GNOME Flashback, such as multimedia keys, screen lock handling, etc. I don't see the point of adding support for something that keeps an obsolete version of GNOME alive, when half of the functionality will be broken. At least GNOME Classic has all the same bits as the stock GNOME session, namely, gnome-shell.
(In reply to Bastien Nocera from comment #4) > (In reply to Yaakov Selkowitz from comment #3) > > (In reply to Bastien Nocera from comment #2) > > > I really don't want to have this in gnome-settings-daemon, handling the > > > dual-settings is already a pain, and I don't want to add another layer on > > > top of that. > > > > Flashback has the same issue as Classic in that we too want to override the > > WM style to be more traditional. Therefore, does it not make sense to > > address the issue in the same code and in the same fashion? > > There are already plenty of things in gnome-settings-daemon which will break > when using GNOME Flashback, such as multimedia keys, screen lock handling, > etc. I don't see the point of adding support for something that keeps an > obsolete version of GNOME alive, when half of the functionality will be > broken. As example - multimedia keys does work. > At least GNOME Classic has all the same bits as the stock GNOME session, > namely, gnome-shell. Would you at least consider accepting very small change in plugins/xsettings/gsd-xsettings-manager.c? Please! - start_shell_monitor (manager); + if (session == NULL || strstr (session, "GNOME-Flashback") == NULL) + start_shell_monitor (manager);
(In reply to Alberts Muktupāvels from comment #5) > (In reply to Bastien Nocera from comment #4) > > (In reply to Yaakov Selkowitz from comment #3) > > > (In reply to Bastien Nocera from comment #2) > > > > I really don't want to have this in gnome-settings-daemon, handling the > > > > dual-settings is already a pain, and I don't want to add another layer on > > > > top of that. > > > > > > Flashback has the same issue as Classic in that we too want to override the > > > WM style to be more traditional. Therefore, does it not make sense to > > > address the issue in the same code and in the same fashion? > > > > There are already plenty of things in gnome-settings-daemon which will break > > when using GNOME Flashback, such as multimedia keys, screen lock handling, > > etc. I don't see the point of adding support for something that keeps an > > obsolete version of GNOME alive, when half of the functionality will be > > broken. > > As example - multimedia keys does work. > > > At least GNOME Classic has all the same bits as the stock GNOME session, > > namely, gnome-shell. > > Would you at least consider accepting very small change in > plugins/xsettings/gsd-xsettings-manager.c? Please! > > - start_shell_monitor (manager); > + if (session == NULL || strstr (session, "GNOME-Flashback") == NULL) > + start_shell_monitor (manager); No. The problem isn't the number of lines of code, it's maintaining them. I will get more of those bug reports when I broke something which I will never test, when a functionality doesn't work because you broke it, or never implemented it. Please, fork it and maintain it. I'm not one bit interested in making more work for myself.