After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738562 - Minimise and maximise buttons are missing in GNOME 3.14 by default
Minimise and maximise buttons are missing in GNOME 3.14 by default
Status: RESOLVED FIXED
Product: gnome-flashback
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Flashback Maintainers
GNOME Flashback Maintainers
Depends on: 745301
Blocks:
 
 
Reported: 2014-10-15 06:55 UTC by Alberts Muktupāvels
Modified: 2015-06-04 14:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Move button-layout to metacity schema (2.11 KB, patch)
2014-10-15 06:56 UTC, Alberts Muktupāvels
none Details | Review
gnome-flashback: Provide WM settings override schema (1.18 KB, patch)
2015-02-27 04:22 UTC, Yaakov Selkowitz
none Details | Review
g-s-d: xsettings: swap out WM settings for Flashback (4.56 KB, patch)
2015-02-27 04:26 UTC, Yaakov Selkowitz
none Details | Review

Description Alberts Muktupāvels 2014-10-15 06:55:10 UTC
Minimise and maximise buttons are missing in GNOME 3.14 by default

1. Wait for session-dependent defaults to GSettings.

2. We could make first-run / welcome window in gnome-flashback module. Where we could ask user if he wants back all buttons. Ask for layout he prefers and then update org.gnome.desktop.wm.preferences button-layout.

This way it should work nice for both sessions - metacity and compiz.
Comment 1 Alberts Muktupāvels 2014-10-15 06:56:34 UTC
Created attachment 288568 [details] [review]
Move button-layout to metacity schema
Comment 2 Yaakov Selkowitz 2015-02-27 02:54:49 UTC
This is worked around in the Classic session by providing a GSettings overrides schema which is used in g-s-d[2].  I believe a solution based on this approach would be more pragmatic.  I am willing to work on a patch if needed.

[1] https://git.gnome.org/browse/gnome-shell-extensions/tree/data/org.gnome.shell.extensions.classic-overrides.gschema.xml.in
[2] https://git.gnome.org/browse/gnome-settings-daemon/tree/plugins/xsettings/gsd-xsettings-manager.c#n334
Comment 3 Yaakov Selkowitz 2015-02-27 04:22:06 UTC
Created attachment 298059 [details] [review]
gnome-flashback: Provide WM settings override schema
Comment 4 Yaakov Selkowitz 2015-02-27 04:26:02 UTC
Created attachment 298060 [details] [review]
g-s-d: xsettings: swap out WM settings for Flashback
Comment 5 Alberts Muktupāvels 2015-02-27 14:05:16 UTC
Thanks for trying to help, but this is not going to be accepted...

GNOME Shell devs are not quite interested in GNOME Flashback so they are not going to accept patch for gsd (which adds flashback specific code).

They even don't want accept patches/changes that could allows us to use session without using org.gnome.Shell dbus name (these changes does not add anything specific to our session):
https://bugzilla.gnome.org/show_bug.cgi?id=739534
Comment 6 Yaakov Selkowitz 2015-02-27 17:25:58 UTC
(In reply to Alberts Muktupāvels from comment #5)
> Thanks for trying to help, but this is not going to be accepted...
> 
> GNOME Shell devs are not quite interested in GNOME Flashback so they are not
> going to accept patch for gsd (which adds flashback specific code).

This patch fixes an issue which also applied to Classic in a similar fashion, therefore from a technical perspective this makes a lot of sense.  If you're on board with this solution, I'm willing to work on getting it into g-s-d.

> They even don't want accept patches/changes that could allows us to use
> session without using org.gnome.Shell dbus name (these changes does not add
> anything specific to our session):
> https://bugzilla.gnome.org/show_bug.cgi?id=739534

That change would have required a corresponding change to gnome-shell; this one would not.
Comment 7 Alberts Muktupāvels 2015-02-27 17:55:43 UTC
(In reply to Yaakov Selkowitz from comment #6)
> (In reply to Alberts Muktupāvels from comment #5)
> > Thanks for trying to help, but this is not going to be accepted...
> > 
> > GNOME Shell devs are not quite interested in GNOME Flashback so they are not
> > going to accept patch for gsd (which adds flashback specific code).
> 
> This patch fixes an issue which also applied to Classic in a similar
> fashion, therefore from a technical perspective this makes a lot of sense. 
> If you're on board with this solution, I'm willing to work on getting it
> into g-s-d.

Classic is official session, Flashback is not and that is big difference. But ok, if you can get gsd patch accepted then I will accept patch for gnome-flashback. Please post here gsd bug link.

> > They even don't want accept patches/changes that could allows us to use
> > session without using org.gnome.Shell dbus name (these changes does not add
> > anything specific to our session):
> > https://bugzilla.gnome.org/show_bug.cgi?id=739534
> 
> That change would have required a corresponding change to gnome-shell; this
> one would not.

that bug is about patches for gnome-session, gnome-shell, gnome-settings-daeomon and of course to this module. And I think this is bigger problem than missing buttons.
Comment 8 Alberts Muktupāvels 2015-06-04 14:24:49 UTC
This will be fixed in next release and is already in master.

I have added workarounds to GNOME Flashback that will take care about setting
Gtk/ShellShowsAppMenu to FALSE and Gtk/DecorationLayout to menu:minimize,maximize,close - can be changed from org.gnome.gnome-flashback.workarounds fix-button-layout setting.

Metacity has been updated to use button layout from GtkSettings.