GNOME Bugzilla – Bug 745064
GTK+3 applications Icons not shown on the taskbar in the Wayland session
Last modified: 2017-11-25 02:21:14 UTC
Created attachment 297728 [details] Screenshot of the GNOME Wayland session with taskbar extension When taskbar extension is enabled, no icon next to the window title is shown in the taskbar for the GTK+3 apps. Icon is properly shown in the top left corner, but not in the taskbar. GTK+2 (XWayland apps) such as firefox appear to be working fine. See the attached screenshot for more details.
By taskbar I mean window list extension from gnome-shell-extensions-3.15.90. And I wanted to add that it works as expected in the X11 session.
(In reply to Armin K. from comment #0) > Screenshot of the GNOME Wayland session with taskbar extension I can't reproduce this for applications with a .desktop file like Settings. Do you see messages in your journal when you open one of those apps? Note that the wayland protocol doesn't provide a way for applications to set an icon. It's expected that the icon is provided by a .desktop file so this is expected for apps without .desktop icons.
Created attachment 297817 [details] [review] window-list: Check if the window title is set MetaWindow.title might be NULL, particularly for Wayland clients where setting the title is a request separate from window creation. We shouldn't try to set StLabel's text prop in that case.
(In reply to Rui Matos from comment #3) > window-list: Check if the window title is set This is something I noticed while trying to reproduce.
Review of attachment 297817 [details] [review]: Sure
Attachment 297817 [details] pushed as c0170ff - window-list: Check if the window title is set
The issue is still present and the provided patch doesn't fix it.
It wasn't supposed to, see comment #2. The issue is that on X we have a fallback for applications without .desktop file, which doesn't exist on Wayland.
Both of the apps in the screenshot have a desktop file and were started from Overview -> Search -> App name. Am I missing something else here? In the top left corner, the icon and application name are like in the desktop file, as the app title for the solitare app (which can be seen on screenshot, Klondike vs AisleRiot Solitare) isn't the same as the title written in the top left corner.
Mmh, we actually stopped using _NET_WM_ICON altogether in bug 694850, so something different is going on here - it *should* work the same on both X11 and wayland ...
(In reply to Armin K. from comment #7) > The issue is still present and the provided patch doesn't fix it. It was for a different issue that I noticed while trying to reproduce. Like I said, I can't reproduce the icon bug. Do you see any messages in your logs that might be related to this?
Mar 05 00:59:56 krejzi org.gnome.Nautilus[9992]: (nautilus:16467): Gdk-CRITICAL **: gdk_window_get_display: assertion 'GDK_IS_WINDOW (window)' failed Mar 05 00:59:56 krejzi org.gnome.gedit[9992]: (gedit:16796): Gdk-CRITICAL **: gdk_window_get_display: assertion 'GDK_IS_WINDOW (window)' failed Mar 05 00:59:56 krejzi org.gnome.gedit[9992]: (gedit:16796): Gdk-CRITICAL **: gdk_device_get_source: assertion 'GDK_IS_DEVICE (device)' failed Mar 05 00:59:56 krejzi org.gnome.gedit[9992]: (gedit:16796): Gdk-CRITICAL **: gdk_device_get_source: assertion 'GDK_IS_DEVICE (device)' failed Mar 05 00:59:56 krejzi org.gnome.gedit[9992]: (gedit:16796): Gdk-CRITICAL **: gdk_device_get_source: assertion 'GDK_IS_DEVICE (device)' failed Mar 05 00:59:56 krejzi org.gnome.gedit[9992]: (gedit:16796): Gdk-CRITICAL **: gdk_device_get_source: assertion 'GDK_IS_DEVICE (device)' failed This is what I see in my journal after I start gedit on a gnome wayland session and the extension enabled. Now mutter-3.15.91, gnome-shell-3.15.91 and gtk+-3.15.10.
This is still an issue with gnome-shell-extensions-3.19.90
Maybe this is related to bug #749074?
No, this applies to the window list extension, both in xorg and wayland sessions. The bug was initially noticed on wayland session, but it applies to xorg session too.
This is still valid for gnome-shell-extensions-3.22.0.
Hello, I have the exact same issue since I'm using Wayland (never had this issue before with X11, and I still don't have it today when I log using X11). I will try to bring more details about this issue based on my two months experience under Wayland. 1 - This issue appears quite randomly, I did not manage to isolate a behavior that provokes it and I did not find any significant info in the logs. But once the issue appears, the only way to get rid of it is to reboot. 2 - It only concerns some applications (only Gnome applications, find the list below), and when this issue appears, it impacts all affected applications. 3 - When this issue happens, it only impacts applications launched afterwards. A workaround that works every time when an icon does not show up is to lock the screen, then relog, and the icon appears. And once the icon appears, it never disappears. 4 - Issue happens even a window of the same application is already opened with a well-displayed icon. For instance, if I have a terminal window opened with a well-displayed icon, the next terminal window I will open would still be affected. This is a (non exhaustive) list of applications that are subject to this issue: gnome-terminal, nautilus, gnome-disks, totem, gnome-screenshot, Cheese, LibreOffice, gnome-mpv And this is a list of applications that are never impacted by this issue: gnome-tweak-tool, gimp, gnome-control-center, evince, gnome-calculator, and pretty much all the applications outside Gnome project (e.g. Atom, Firefox, Filezilla, Chrome,..) I hope it is clearer now.. PS: I'm running Gnome on Archlinux.
Hello, I can confirm this issue, but not exactly the same than the previous comment. Fedora 25 + Gnome 3.22 + Wayland Doesn't happen under Xorg. Version used: gnome extensions website - tried with git version, same results Some icons appear once (at app' first launch) then never show again, some icons never appear at all (99% of my apps, including GNOME ones and those listed as "never impacted" by BenLC), even after lock/unlock and other workarounds explained in comments. When I say that an icon doesn't appear, I mean that it only shows the "missing icon" of course. By the way, this issue doesn't exist (at least for me) when grouping-mode is set to "always". But grouping mode has another (minor) issue, minimized style in CSS doesn't affect minimized *grouped* windows.
Hello, Update: I switched to Fedora 26 + Gnome 3.24 + Wayland yesterday and I still have the same issue (see previous comment).
Issue still exists on Gnome 3.26.1/Wayland (Arch).
Created attachment 362954 [details] [review] Update icon by app-state-changed signal
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/10.