After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 694850 - window-list missing icons
window-list missing icons
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: extensions
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-02-28 10:51 UTC by Matthias Clasen
Modified: 2013-03-02 19:58 UTC
See Also:
GNOME target: 3.8
GNOME version: ---

Attachments
screenshot (165.27 KB, image/png)
2013-02-28 10:51 UTC, Matthias Clasen 		  Details
window-list: Always use ShellApp icon rather than _NET_WM_ICON (2.35 KB, patch)
2013-02-28 17:32 UTC, Florian Müllner 		committed Details | Review

Description Matthias Clasen 2013-02-28 10:51:31 UTC 
Created attachment 237585 [details]
screenshot

I've noticed that the window list sometimes doesn't get the right application icon, even when it shows up properly in the app menu
Comment 1 Florian Müllner 2013-02-28 11:24:11 UTC 
Yes, app menu and window list use different icons - the former uses the application icon (preferably from the .desktop file), the latter the window icon (most likely _NET_WM_ICON).
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-02-28 14:46:52 UTC 
We should probably fall back to the app icon in that case.
Comment 3 Florian Müllner 2013-02-28 14:50:01 UTC 
Nah, the easiest fix is to just use the app icon from the get-go ...
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-02-28 14:54:05 UTC 
Does anything use a _NET_WM_ICON that's different from the app icon? I can't imagine so, but it would break GNOME 2 people, so we should be careful.
Comment 5 Florian Müllner 2013-02-28 15:04:13 UTC 
Some applications (gnome-documents comes to mind) have started to not set _NET_WM_ICON at all (in which care there's a fallback to some generic icon); ShellApp already falls back to _NET_WM_ICON in case we can't find a .desktop file, so this should be fine (in particular as it's consistent with any other place, e.g. dash, app menu, tab popup, ...)
Comment 6 Florian Müllner 2013-02-28 17:32:30 UTC 
Created attachment 237631 [details] [review]
window-list: Always use ShellApp icon rather than _NET_WM_ICON

We currently use the application icon for items that are grouped
by application and the window icon otherwise. However with the
icon property being unused anywhere else in GNOME3, applications
have started to not set any window icon at all.
Rather than complaining to application authors, switch to using
the app icon everywhere, which improves consistency with the rest
of GNOME3 anyway.
Comment 7 drago01 2013-03-02 11:02:53 UTC 
Review of attachment 237631 [details] [review]:

Looks good.
Comment 8 Florian Müllner 2013-03-02 19:58:47 UTC 
Attachment 237631 [details] pushed as 040c106 - window-list: Always use ShellApp icon rather than _NET_WM_ICON