GNOME Bugzilla – Bug 744464
No results screen for Search
Last modified: 2015-07-13 13:53:47 UTC
We should make a new view for search when no results found
This could reuse visuals from the "empty states" designs: https://wiki.gnome.org/Design/OS/EmptyStates Just change the text: "No music found" "Try a different search"
Created attachment 305699 [details] [review] Adding a view for searches with no result Added a new view which uses the NoMusic.ui with a different text as Allan proposed.
I've just tried the patch, and it looks great from a UI point of view. :)
Oh, one issue I just noticed, though: if you cancel a search (by pressing escape or the search button), the search view should disappear, and the previous view should be reinstated. This doesn't seem to happen with the "no search results" screen.
I see, also clicking on the selection mode makes it crash since there is no player object in the view, and there are probably more problems that I've missed... I'll continue working on this, see where I can get.
Created attachment 305734 [details] [review] Adding a view for searches with no result Fixed the mentioned issues and used signals instead of throwing codes around. Though right now selection mode can get activated even when no search results are found, is this the expected behavior or the button should not be sensitive while no results are found?
(In reply to Hapoofesgeli from comment #6) > Created attachment 305734 [details] [review] [review] > Adding a view for searches with no result Looks great! > Though right now selection mode can get activated even when no search > results are found, is this the expected behavior or the button should not be > sensitive while no results are found? Lets make it disabled as soon as we enter this screen.
Created attachment 305847 [details] [review] Adding a view for searches with no result Added toggling the sensitivity of the selection button when dealing with EmptySearch view. Also fixed some problems with getting back to the right view after canceling the search.
Thanks, pushed https://git.gnome.org/browse/gnome-music/commit/?id=ed1059b to master
Great, thanks Hapoofesgeli!
New string ("Try a different search") is not marked for translation.
(In reply to Piotr Drąg from comment #11) > New string ("Try a different search") is not marked for translation. Oops, overlooked this one. Fixed in https://git.gnome.org/browse/gnome-music/commit/?id=23a6bff
There are currently problems with different sources/filters in search and the EmptySearch view gets shown when there are actually some external results to show and this breaks the usage of search options. And I'm still trying fix that issue but I'm yet to find a proper way of finding out how many search results we actually get at the end, and in the way the "All" source shows up some weird behaviors which create some other problems... Also there are some other small issues but they are not too hard to fix.
Created attachment 306923 [details] [review] Fixing some bugs related to the EmptySearch view *Disabling the view for multiple-source searches till I get more info on Bug 751890, with this patch the view will work for local and Jamendo searches and later on Magnatune if the bug gets fixed. After that I'll fix it for searches with multiple sources too. *Fixed the wrong showing up of the view when there is only one song result to show.
(In reply to Hapoofesgeli from comment #14) > Created attachment 306923 [details] [review] [review] > Fixing some bugs related to the EmptySearch view Pushed as https://git.gnome.org/browse/gnome-music/commit/?id=ab6d99f to master
Created attachment 307165 [details] [review] Fixing wrong showing ups of the EmptySearch view in external sources
Review of attachment 307165 [details] [review]: Thanks, pushed as https://git.gnome.org/browse/gnome-music/commit/?id=c878246
Review of attachment 306923 [details] [review]: .
Review of attachment 305847 [details] [review]: .