GNOME Bugzilla – Bug 751890
Magnatune plugin doesn't invoke the callback in search operations with 0 result
Last modified: 2015-07-15 08:59:58 UTC
Unlike other plugins like Jamendo, Magnatune doesn't invoke the callback in search operations when no results are found. And there are no logs about the operation getting finished. Grilo-DEBUG: [source] grl-source.c:3875: requested fast keys Grilo-DEBUG: [source] grl-source.c:1032: operation_set_ongoing (21) Grilo-DEBUG: [source] grl-source.c:2482: search_idle Grilo-DEBUG: [source] grl-source.c:893: operation_set_started (21) Grilo-DEBUG: [magnatune] grl-magnatune.c:891: magnatune_execute_search Grilo-DEBUG: [magnatune] grl-magnatune.c:681: magnatune_sqlite_execute Grilo-DEBUG: [magnatune] grl-magnatune.c:545: magnatune_check_update
Created attachment 307450 [details] [review] magnatune: Fix search never finishing if no results When no results are returned from a search, we'd skip to the error path, but without an error to return. Thus, we'd never mark the search operation as finished.
Review of attachment 307450 [details] [review]: Looks good! Tested with grl-launch: GRL_DEBUG=magnatune:* grl-launch-0.2 -k title -S search nonexist grl-magnatune
Attachment 307450 [details] pushed as 64767da - magnatune: Fix search never finishing if no results