After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 744413 - Stop using deprecated gnome-common macros
Stop using deprecated gnome-common macros
Status: RESOLVED FIXED
Product: atk
Classification: Platform
Component: atk
git master
Other Linux
: Normal normal
: ---
Assigned To: ATK maintainer(s)
ATK maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-02-12 17:51 UTC by Javier Jardón (IRC: jjardon)
Modified: 2015-02-19 02:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use AX_COMPILER_FLAGS (43.35 KB, patch)
2015-02-12 17:51 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Stop using GNOME specific autoconf macros (703 bytes, patch)
2015-02-18 12:24 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2015-02-12 17:51:48 UTC 
Created attachment 296707 [details] [review]
Use AX_COMPILER_FLAGS

https://wiki.gnome.org/Projects/GnomeCommon/Migration
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2015-02-16 09:42:52 UTC 
Review of attachment 296707 [details] [review]:

Although the patch looks good, and probable desirable, applying it have the consecuence of atk not compiling, as some warnings are detected as errors. So I think that as part of this bug, if we want to apply that patch, those warnings would need to be solved.
Comment 2 Javier Jardón (IRC: jjardon) 2015-02-18 12:24:47 UTC 
Created attachment 297092 [details] [review]
Stop using GNOME specific autoconf macros

What about this? The  we can open another bug to use AX_COMPILER_FLAGS
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2015-02-18 15:17:48 UTC 
Review of attachment 297092 [details] [review]:

LGTM
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2015-02-18 15:18:23 UTC 
(In reply to Javier Jardón (IRC: jjardon) from comment #2)
> Created attachment 297092 [details] [review] [review]
> Stop using GNOME specific autoconf macros
> 
> What about this? The  we can open another bug to use AX_COMPILER_FLAGS

Makes sense. Could you create that another bug, please?
Comment 5 Javier Jardón (IRC: jjardon) 2015-02-19 02:20:39 UTC 
Review of attachment 297092 [details] [review]:

commit 93ab14e7dd0036243269dedd5569cdb5cc26f513
Comment 6 Javier Jardón (IRC: jjardon) 2015-02-19 02:26:23 UTC 
(In reply to Alejandro Piñeiro Iglesias (IRC: infapi00) from comment #4)
> (In reply to Javier Jardón (IRC: jjardon) from comment #2)
> > Created attachment 297092 [details] [review] [review] [review]
> > Stop using GNOME specific autoconf macros
> > 
> > What about this? The  we can open another bug to use AX_COMPILER_FLAGS
> 
> Makes sense. Could you create that another bug, please?

https://bugzilla.gnome.org/show_bug.cgi?id=744768