Created attachment 297239 [details] [review]
Use AX_COMPILER_FLAGS

This will eventually applied when all the compiler warnings get fixed

Review of attachment 297239 [details] [review]:

::: configure.ac
@@ -260,3 @@
 AC_SUBST(ATK_HIDDEN_VISIBILITY_CFLAGS)
 
-GNOME_COMPILE_WARNINGS([maximum])

You uploaded exactly the first same patch uploaded at 744413. The second patch (committed), include this line too. That means that this patch doesn't apply directly. Sorry for be too demanding, but, could you update the patch? Thanks

(In reply to Javier Jardón (IRC: jjardon) from comment #1)
> Created attachment 297239 [details] [review] [review]
> Use AX_COMPILER_FLAGS
> 
> This will eventually applied when all the compiler warnings get fixed

Is not only that there are warnings, but that with this change, all warnings are treated as errors now:

"atkobject.c:276:1: error: function declaration isn't a prototype [-Werror=strict-prototypes]
 initialize_role_names ()
 ^
atkobject.c: In function 'initialize_role_names':
atkobject.c:276:1: error: old-style function definition [-Werror=old-style-definition]
atkobject.c: In function 'atk_object_real_set_property':
atkobject.c:1320:9: error: 'atk_value_set_current_value' is deprecated (declared at ../atk/atkvalue.h:136): Use 'atk_value_set_value' instead [-Werror=deprecated-declarations]
         atk_value_set_current_value (ATK_VALUE (accessible), value);
         ^
atkobject.c: In function 'atk_object_real_get_property':
atkobject.c:1369:9: error: 'atk_value_get_current_value' is deprecated (declared at ../atk/atkvalue.h:126): Use 'atk_value_get_value_and_text' instead [-Werror=deprecated-declarations]
         atk_value_get_current_value (ATK_VALUE (accessible), value);
         ^
atkobject.c: In function 'atk_role_for_name':
atkobject.c:1630:17: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
   for (i = 0; i < role_names->len; i++)
                 ^
cc1: all warnings being treated as errors"

AFAIR, some modules as clutter explicitly avoid setting all warnings as errors. What are they policy now, in relation with this gnome-macros deprecation?

Created attachment 297363 [details] [review]
Use AX_COMPILER_FLAGS.V2

Sorry, here the updated patch

(In reply to Alejandro Piñeiro Iglesias (IRC: infapi00) from comment #3)
> (In reply to Javier Jardón (IRC: jjardon) from comment #1)
> > Created attachment 297239 [details] [review] [review] [review]
> > Use AX_COMPILER_FLAGS
> > 
> > This will eventually applied when all the compiler warnings get fixed
> 
> Is not only that there are warnings, but that with this change, all warnings
> are treated as errors now:
> 
<snip>
> 
> AFAIR, some modules as clutter explicitly avoid setting all warnings as
> errors. What are they policy now, in relation with this gnome-macros
> deprecation?

I think the idea is that werror is active if you are a developer (usin git) and disabled in releases

GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of atk, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a ticket at
  https://gitlab.gnome.org/GNOME/atk/-/issues/

Thank you for your understanding and your help.