After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743191 - Replace custom functions by standard NSIS functions and bring some logic
Replace custom functions by standard NSIS functions and bring some logic
Status: RESOLVED OBSOLETE
Product: dia
Classification: Other
Component: install
CVS head
Other Windows
: Normal minor
: ---
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2015-01-19 17:25 UTC by Bart.S
Modified: 2019-03-20 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch replacing GetParent and introducing LogicLib (6.16 KB, patch)
2015-01-19 17:33 UTC, Bart.S 		none Details | Review
Patch replacing GetParent, GetParameters and introducing LogicLib (8.88 KB, patch)
2015-01-20 10:37 UTC, Bart.S 		none Details | Review
Patch replacing GetParent, GetParameters and introducing LogicLib (8.88 KB, patch)
2015-01-20 10:45 UTC, Bart.S 		none Details | Review
Patch replacing GetParent, GetParameters, GetParameterValue and introducing LogicLib (15.65 KB, patch)
2015-01-20 14:00 UTC, Bart.S 		none Details | Review
Patch replacing GetParent, GetParameters, GetParameterValue and introducing LogicLib (15.65 KB, patch)
2015-01-20 14:23 UTC, Bart.S 		none Details | Review
Patch replacing custom functions, introducing LogicLib and some cleanup (24.16 KB, patch)
2015-01-21 13:38 UTC, Bart.S 		none Details | Review
Patch replacing custom functions, introducing LogicLib and some cleanup (24.10 KB, patch)
2015-01-22 10:07 UTC, Bart.S 		none Details | Review
Patch replacing custom functions, introducing LogicLib and some cleanup (28.29 KB, patch)
2015-01-22 13:33 UTC, Bart.S 		none Details | Review
Patch replacing custom functions, introducing LogicLib and some cleanup (32.43 KB, patch)
2015-01-22 13:37 UTC, Bart.S 		none Details | Review
Patch replacing custom functions, introducing LogicLib and some cleanup (32.44 KB, patch)
2015-01-23 10:08 UTC, Bart.S 		none Details | Review
Patch replacing custom functions, introducing LogicLib and some cleanup (32.37 KB, patch)
2015-01-26 14:38 UTC, Bart.S 		none Details | Review

Description Bart.S 2015-01-19 17:25:56 UTC 
The Windows installer script includes some custom functions: 
GetParent, GetParameters, ...

NSIS has these included nowadays. 

This patch replaces GetParent and introduces LogicLib for better readability of code.

More to follow...
Comment 1 Bart.S 2015-01-19 17:33:10 UTC 
Created attachment 294904 [details] [review]
Patch replacing GetParent and introducing LogicLib
Comment 2 Bart.S 2015-01-20 10:36:06 UTC 
Version 2 of the patch replaces GetParameters too and switch more conditions to LogicLib.
Comment 3 Bart.S 2015-01-20 10:37:38 UTC 
Created attachment 294969 [details] [review]
Patch replacing GetParent, GetParameters and introducing LogicLib
Comment 4 Bart.S 2015-01-20 10:45:52 UTC 
Created attachment 294970 [details] [review]
Patch replacing GetParent, GetParameters and introducing LogicLib
Comment 5 Bart.S 2015-01-20 13:59:11 UTC 
Patch version 3 is here. ;)
Additionally to version 2 the custom functions GetParameterValue, StrStr have been removed. And more logic cleanup.
Comment 6 Bart.S 2015-01-20 14:00:37 UTC 
Created attachment 294994 [details] [review]
Patch replacing GetParent, GetParameters, GetParameterValue and introducing LogicLib
Comment 7 Bart.S 2015-01-20 14:23:36 UTC 
Created attachment 294997 [details] [review]
Patch replacing GetParent, GetParameters, GetParameterValue and introducing LogicLib
Comment 8 Bart.S 2015-01-21 13:37:18 UTC 
Version 4 of the patch is the last one for now I hope.
It does more functions and logic cleanup. 
And fixes a bug when Dia is build/packaged without GTK (the command line option where to find GTKBIN was never read due to funny jumps in code).
Comment 9 Bart.S 2015-01-21 13:38:31 UTC 
Created attachment 295100 [details] [review]
Patch replacing custom functions, introducing LogicLib and some cleanup
Comment 10 Bart.S 2015-01-22 10:07:08 UTC 
Version 5 changes the loop at the beginning of the 'VerifyDir'-function. This might fix bug #690228.
Comment 11 Bart.S 2015-01-22 10:07:55 UTC 
Created attachment 295154 [details] [review]
Patch replacing custom functions, introducing LogicLib and some cleanup
Comment 12 Bart.S 2015-01-22 13:32:59 UTC 
Patch version 6 is ready. Sorry, it wasn't my intention to do so many versions but now things are better sorted IMHO. This is really the last one if no bugs are found. Feedback is welcome.
Comment 13 Bart.S 2015-01-22 13:33:41 UTC 
Created attachment 295167 [details] [review]
Patch replacing custom functions, introducing LogicLib and some cleanup
Comment 14 Bart.S 2015-01-22 13:37:25 UTC 
Created attachment 295168 [details] [review]
Patch replacing custom functions, introducing LogicLib and some cleanup
Comment 15 Bart.S 2015-01-23 10:07:47 UTC 
Another small update. Patch 7 changes some signed integer tests to case-insensitive string tests.
Comment 16 Bart.S 2015-01-23 10:08:27 UTC 
Created attachment 295262 [details] [review]
Patch replacing custom functions, introducing LogicLib and some cleanup
Comment 17 Bart.S 2015-01-26 14:37:31 UTC 
Version 8 is here. The installer is using "VersionCompare" for detected GTK now.
Comment 18 Bart.S 2015-01-26 14:38:03 UTC 
Created attachment 295455 [details] [review]
Patch replacing custom functions, introducing LogicLib and some cleanup
Comment 19 GNOME Infrastructure Team 2019-03-20 12:04:21 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/dia/issues/350.