After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 743056 - [4.4] Impossible to find [Browse] product overview page from bug report: Link via "Browse" in top bar
[4.4] Impossible to find [Browse] product overview page from bug report: Link...
Status: RESOLVED FIXED
Product: bugzilla.gnome.org
Classification: Infrastructure
Component: general
unspecified
Other Linux
: High normal
: ---
Assigned To: André Klapper
Bugzilla Maintainers
: 744314 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-01-16 17:12 UTC by André Klapper
Modified: 2015-02-25 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description André Klapper 2015-01-16 17:12:20 UTC
Comparing
https://bugzilla.gnome.org/show_bug.cgi?id=123456 and
https://bugzilla-test.gnome.org/show_bug.cgi?id=123456
we had that box in the corner and clicking on the Product name brings you to the overview page. Now there is no link anymore.

Wondering whether I should hack up a "[Product overview]" link next to the Product dropdown (not too complicated but increasing our diff).
Comment 1 André Klapper 2015-01-16 21:24:54 UTC
My idea was to edit template/en/custom/bug/edit.html.tmpl and simply replace the link in front of the "Product:" dropdown in show_bug.cgi, like replacing
         desc_url = 'describecomponents.cgi'
to become
         desc_url = "page.cgi?id=browse.html&product=$bug.product"
somewhere around https://git.gnome.org/browse/bugzilla-gnome-org-upstream/tree/template/en/default/bug/edit.html.tmpl?h=4.4#n229
but not sure how to populate that parameter value correctly so it's not taken literally.
Comment 2 Olav Vitters 2015-01-19 12:12:29 UTC
We could also just completely override describecomponents.cgi. Basically have reports/components.html.tmpl which just does a PROCESS pages/browse.html (something like this).

bug/edit.html.tmpl is quite long, so just changing a link is pretty invasive.
Comment 3 André Klapper 2015-01-24 18:21:22 UTC
@Olav: See my comment in bug 743027#c7 however I cannot really test patches much currently (travelling with a different machine) except for on the server :P
Comment 4 André Klapper 2015-02-24 22:24:27 UTC
*** Bug 744314 has been marked as a duplicate of this bug. ***
Comment 5 André Klapper 2015-02-24 22:41:52 UTC
Olav's approach in bug 744314 (use the "Browse" link in the top bar by passing the bug.product parameter is way cleaner:

https://git.gnome.org/browse/bugzilla-gnome-org-customizations/commit/?id=ce0cc63b87b83c6a6a283c588445e0ea335e8633
Comment 6 André Klapper 2015-02-24 22:48:08 UTC
In theory deployed in production: https://git.gnome.org/browse/bugzilla-gnome-org-customizations/commit/?h=production&id=1c04ffd8f1822146deed898dcad803a6f139f90b

In practice I don't see anything yet, looking at the link target of the "Browse" link in the top bar (Home | New | Browse | Search) which should be https://bugzilla.gnome.org/page.cgi?id=browse.html&product=bugzilla.gnome.org here instead of https://bugzilla.gnome.org/page.cgi?id=browse.html
Comment 7 André Klapper 2015-02-24 22:56:41 UTC
Nope, something is fishy. I saw it working exactly once and all the other time it does not. Would love to see output / errors from the server here... @av?
Comment 8 Andrea Veri 2015-02-25 07:46:48 UTC
It seems to be working just fine here and curl confirms too:

<li><span class="separator">| </span><a href="page.cgi?id=browse.html&product=bugzilla.gnome.org">Browse</a></li>

Cache issue on your end as I originally suggested?
Comment 9 André Klapper 2015-02-25 08:48:16 UTC
Andrea: Works fine now too here. Thanks for checking. Let's agree on cache issue on my end...Meh.
Sorry for the noise but don't want to break more things than needed (and looking forward to a testing instance where I can wait for one day to let cache issues vanish before pulling to production, I guess).
Comment 10 Olav Vitters 2015-02-25 09:15:17 UTC
You actually want FILTER uri for gtk+ -> gtk%2B. I'll commit a fix.