Bug 123456 - ItemFactory.create_items and <ImageItem> bug
ItemFactory.create_items and <ImageItem> bug
Status: RESOLVED FIXED
Product: pygtk
Classification: Bindings
Component: general
1.99.x/2.0.x
Other Linux
: Normal normal
: ---
Assigned To: Python bindings maintainers
Python bindings maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2003-09-29 11:22 UTC by Rob Melby
Modified: 2005-08-22 12:44 UTC (History)
0 users

See Also:
GNOME target: ---
GNOME version: ---


Attachments
aforementioned patch (1.18 KB, patch)
2003-09-29 11:23 UTC, Rob Melby
none Details | Diff | Review

Description Rob Melby 2003-09-29 11:22:07 UTC
according to the pygtk function for create_items, if the item 
is an <ImageItem>, the extra data should be either a string 
or a pixbuf.  

the C create_items function actually only appears to take inline data
(it internally creates a pixbuf from it).

attached is a patch against 2.0.0 to make it function correctly 
if passed a pixbuf.  the pixbuf is first serialized and then passed
to the C function.  the memory created is then owned by the itemfactory's
internal pixbuf.
Comment 1 Rob Melby 2003-09-29 11:23:54 UTC
Created attachment 20349 [details] [review]
aforementioned patch
Comment 2 Johan (not receiving bugmail) Dahlin 2003-10-23 18:10:13 UTC
Fixed in cvs head and pygtk-2-0 branch, thanks for the patch

Note You need to log in before you can comment on or make changes to this bug.