After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 741808 - title-box: Don't flash the location entry between page loads
title-box: Don't flash the location entry between page loads
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 755518
 
 
Reported: 2014-12-20 16:28 UTC by Michael Catanzaro
Modified: 2016-09-11 03:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
title-box: Don't flash the location entry between page loads (1.42 KB, patch)
2014-12-20 16:28 UTC, Michael Catanzaro
needs-work Details | Review
title-box: Don't flash the location entry between page loads (4.64 KB, patch)
2015-02-06 22:52 UTC, Michael Catanzaro
none Details | Review
title-box: Don't flash the location entry between page loads (4.65 KB, patch)
2015-03-29 03:12 UTC, Michael Catanzaro
needs-work Details | Review

Description Michael Catanzaro 2014-12-20 16:28:10 UTC
The location entry shouldn't appear when navigating between pages, nor when refreshing the current page.
Comment 1 Michael Catanzaro 2014-12-20 16:28:11 UTC
Created attachment 293130 [details] [review]
title-box: Don't flash the location entry between page loads

This fixes the distracting flicker when the title box switches from
title mode to location entry mode when loading a page.
Comment 2 Carlos Garcia Campos 2015-02-03 12:07:19 UTC
Review of attachment 293130 [details] [review]:

::: src/ephy-title-box.c
@@ -471,3 @@
-      !title || *title == '\0') {
-    ephy_title_box_set_mode (title_box, EPHY_TITLE_BOX_MODE_LOCATION_ENTRY);
-    return;

The idea is that for pages with no title, we show the location entry. This patch breaks that. Open a bugzilla page with an attachment, for example, and click in the attachment. The location entry should be shown, but the title is shown instead.
Comment 3 Michael Catanzaro 2015-02-06 22:52:00 UTC
Created attachment 296308 [details] [review]
title-box: Don't flash the location entry between page loads

This fixes the distracting flicker when the title box switches from
title mode to location entry mode when loading a page.
Comment 4 Michael Catanzaro 2015-03-29 03:12:10 UTC
Created attachment 300531 [details] [review]
title-box: Don't flash the location entry between page loads

Just fixed a missing type-check cast
Comment 5 Michael Catanzaro 2015-04-05 13:26:49 UTC
Review of attachment 300531 [details] [review]:

With this patch it's possible that the URL is displayed in the subtitle before there is a title for the page. More work needed to ensure the subtitle is not set until the title is ready.