Created attachment 295313 [details] [review]
Add accelerators to composer toolbar

This adds the accelerators to the tooltips.  It should also add an 
accelerator for "Attach file" (Ctrl+T, for aTtach, as A is taken for 
select all and F for find).  But this doesn't work, and I can't figure 
out why.  It's not that T is taken -- I can swap accelerators with 
detach, for example, and detach works with Ctrl+T but Ctrl+D doesn't do 
anything.

(In reply to comment #1)
> It should also add an 
> accelerator for "Attach file" (Ctrl+T, for aTtach, as A is taken for 
> select all and F for find).  But this doesn't work, and I can't figure 
> out why.  It's not that T is taken -- I can swap accelerators with 
> detach, for example, and detach works with Ctrl+T but Ctrl+D doesn't do 
> anything.

Weird!  I don't see any rhyme or reason for this.  I banged on this for a few minutes and can't see anything wrong, not even the key being trapped programmatically elsewhere.  I tried Ctrl+H too, but no success.

In any event, this sounds like a separate ticket.  I say remove the accelerator and added tooltip text for attach and commit the rest of this.  Then ticket this problem.

Note that if we do add an accelerator, we need to add it to the help docs as well.

Attachment 295313 [details] pushed as 45a67f5 - Add accelerators to composer toolbar

The attach file accelerator issue is filed as bug 743565.