GNOME Bugzilla – Bug 741047
Same window for troubleshoot log & file selection
Last modified: 2016-03-31 13:22:07 UTC
This is quite the same as bug#741046 but for dialogs launched from properties window. We have mockup for troubleshooting log here: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/boxes/wires/properties-modal.png
Troubleshooting log view fixed with following patches: commit 7adb5f47e830da40cfcadef13f27144e1e290409 properties: Refactor PageWidget into its own class/module Lets avoid confusing (to code readers) nested classes and move PageWidget out of Properties class into its own module with a new name, PropertiesPageWidget. commit 5b4927bbd6e4f1114a545ea14ed57cbcb02a0958 libvirt-machine-props: Use notifications for errors Instead of launching a dialog on failing to save troubleshooting log, use notifications. Known issue: The troubleshooting log is itself a dialog that hides the properties window at the moment so the notification is hidden unless user closes the dialog soon (a few seconds) after choosing the file. This issue will be resolved after we merge troubleshooting log UI into the properties window itself. commit 65206a8e28026aa0750c657f3978d2029fa0e98d properties-toolbar: Keep a ref to PropertiesWindow We'll need this from PropertiesToolbar in the following patches. commit 29f9d1527e89c165073da7b9974abce4cd55e378 properties-window: Add revert_state() Add a public method to revert the state to whatever it was before we arrived at 'properties' state or 'collection' state if last state doesn't make sense, and make use of this method in both PropertiesWindow itself and PropertiesToolbar. commit da2e596e1e7c1a98ebbf7f0c97976ba562651cf0 properties-toolbar: Handle buttons' visibility PropertiesToolbar now handle the visibility of its buttons itself. commit 25a6c894c0e7ff583f921ca6584844b9835c7a9f Introducing TroubleshootLog widget This simple widget will be used in the following patches to show troubleshooting log to user, to replace the dialog we use currently. commit dc7fc8458c565aff3868f4eae4b725b94ece17ce properties-window: API to show troubleshooting log Add a view and API to show troubleshooting log to user. commit 4a6e7a4653b27fe021bccdc4b3f5c243b9ac69c2 properties-window: Add copy_troubleshooting_log_to_clipboard() Add API to copy the contents of troubleshooting log to clipboard. commit 93c15c640055c1cb92642b88136003136bfe1d87 properties-toolbar: Content for troubleshooting log view The properties topbar should provide a different set of controls and title when troubleshooting log view is visible in the properties window. commit 61fde557ff56e3f99457848f27492984dcdb2aba libvirt-machine-props: Drop troubleshoot log dialog Instead of creating and launching a separate dialog to show troubleshooting log to user, use the new PropertiesWindow API to do so. Nested dialogs is something we want to avoid according to our designers. commit 5b49b21377c421fe554b82869d4a7c1f83494a4a properties-toolbar: Add click_back_button() Add API to click the appropriate back button in the properties topbar, depending on which headerbar is current. commit aa91ab3da66813b1c54d43a85e30ed31517e84a1 properties-window: Go back on Alt+Left key combo Go back to main page on Alt+Left key combo.
commit f23b7f9a58f6da661bdc97a93eaf241274cfb9fe properties-*: troubleshooting_log -> troubleshoot_log Use shorter name since it's not ambiguous. commit 2681d1bcda27c39bab7d4f09e9ae397764da74ef properties-window: API to show file chooser widget Add a view and API to show file chooser to user. commit 3a60e4f91b31a51de5299b802b25b34eb942f20b properties-toolbar: Content for file chooser view The properties topbar should provide a different set of controls and title when file chooser view is visible in the properties window. commit 7011b7f7f62cb764ce17e1a245f2a51541557f81 libvirt-machine-props: Drop use of file chooser dialog Instead of creating and launching a separate dialog to let user select ISO960 files/devices, use the new PropertiesWindow API to present an in-view file chooser. Nested dialogs is something we want to avoid according to our designers. commit e8d585ed873bc153a0d07a4c6d62340cee2511ae properties-*: Request size 1024x768 The properties window is currently very small and it looks ugly, especially now with FileChooser view in it. Lets give it a decent size. commit 065bd43f799f2436a503b72c634cf753726c8719 properties-window: Appy 'content-bg' style to view stack This makes troubleshooting log view look more like the UI mockup.