GNOME Bugzilla – Bug 741046
Same window for customization & file selection
Last modified: 2016-03-31 13:22:00 UTC
With wizard now in a separate dialog-like window, launching dialogs from it looks weird/bad. We already have mockups for fixing this: https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/boxes/wires/newbox-assistant.png Although it doesn't cover file chooser dialog, we can re-use the same design as for 'customization' page, but show file chooser widget in there.
Customization part is done now with these patches: commit: e3d4092b2386e6cc618039547459b0e6aac8bc74 wizard: review() now public We'll need to call it from WizardWindow in a following patch. commit: b550b77770795cc0699951dba78c410d8b43c60e wizard-window: API to show resource customization UI Add a view and API to show resources customization UI. commit: 71158d2a0e58d4088c14079fdef30ed38b45f583 wizard: Make use of new customization view/API Instead of launching properties view on user hitting 'Customize' button, show the new resource customization UI. This means that now user can only customize resources before hitting 'Create' button but that is fine because resources are typically the only properties that users want to customize before machine is launched for the first time. Also this bebavior/UI is according to the new mockups. commit: dc99be26401974c87eb990ea4b651821b54b30f6 wizard: Only LibvirtMachine is customizable Now that customization during wizard only includes system resources, it doesn't make sense to provide this option for any other type of boxes than LibvirtMachine. commit: c271dd19c994db69bddb97dfcf5d092b8074aefa app-window: Remove redundant wizard->properties code Remove now redundant code to launch properties from wizard. commit: 4d579b5bae1d3d3c53f44abea7f527a383184418 wizard-toolbar: Keep a ref to WizardWindow WizardToolbar now keeps an unowned reference to its parent WizardWindow. commit: ef349c833214ef1e45495b1e82992acbb451ede8 wizard-toolbar: Content for customization view The wizard topbar should provide a different set of controls and title when customization view is visible in the wizard window. commit: c016a7db4f29dddbdc30cdc2fa29778466012c78 libvirt-machine-props: Customization doesn't change UI state The UI remains to be in wizard state when customizing now so the check for UI state needs to be updated. commit: 672ed53132dcfe466ecf0512fe84d29900ac565a properties-toolbar: Drop main_back_button The 'Back' button in main view was only needed for wizard->properties case and now we don't have this UI transition anymore so this button is now redundant. commit: 72e48d2844a2eb6c23f9490d7120566634f6df58 properties-toolbar: Always show 'x' button We didn't show 'x' (close) button when coming to properties from wizard but now that UI transition doesn't happen. So there is no need anymore to update the visibility of this button. commit: 7b011de41d1279f80d1dc85c7dc57ce61718a14e properties: Always start with 'General' page We go straight to 'System' page if coming from wizard state but now we never arrive from wizard to properties so there is no need for code to switch to 'System' page anymore. commit: f9134bd3f16aa6d0162822a6e2fefa0f8a9eb49b wizard: Always start with 'Introduction' page We go straight to 'Review' page if coming from properties state but now we never arrive from properties to wizard so there is no need for code to switch to 'Review' page anymore.
commit: 90f263657f65754f2c71324ccbc0e1045b8e08b9 wizard-window: API to show file chooser widget Add a view and API to show file chooser to user. commit: 8f7c3655845bb557b33f365917b106dfa0821a3d wizard-toolbar: Content for file chooser view The wizard topbar should provide a different set of controls and title when file chooser view is visible in the properties window. commit: dec5863b97f4eab95dcafcc5aee3a981d2e5af87 wizard-source: Drop use of file chooser dialog Instead of creating and launching a separate dialog to let user select ISO960 files/devices, use the new WizardWindow API to present an in-view file chooser. Nested dialogs is something we want to avoid according to our designers. commit: 2e36911106e3117191a17eb9d446185c7215a1dd wizard-window: Request size 1024x768 The wizard window is currently very small and it looks ugly, especially now with FileChooser view in it. Lets give it a decent size.