After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740417 - Don't scale up thumbnails
Don't scale up thumbnails
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.14.x
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-11-20 11:16 UTC by Allan Day
Modified: 2017-03-02 07:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
base-item: Don't scale up thumbnails (4.46 KB, patch)
2014-11-22 09:41 UTC, Debarshi Ray 		none Details | Review
Screenshot - thumbnails with emblems (160.82 KB, image/png)
2014-11-22 09:44 UTC, Debarshi Ray 		  Details
base-item, utils: Don't scale up thumbnails (v2) (6.47 KB, patch)
2014-11-25 14:31 UTC, Debarshi Ray 		reviewed Details | Review
Screenshot - thumbnails with emblems (v2) (161.24 KB, image/png)
2014-11-25 14:32 UTC, Debarshi Ray 		  Details
base-item, utils: Don't scale up thumbnails (5.54 KB, patch)
2014-11-28 11:10 UTC, Debarshi Ray 		committed Details | Review

Description Allan Day 2014-11-20 11:16:58 UTC 
I have a few small images in ~/Pictures. In the Photos thumbnail grid, the thumbnails are bigger than the actual image. This causes the thumbnail to be fuzzy.

It would probably better to ensure that the thumbnails are never bigger than the actual image.
Comment 1 Debarshi Ray 2014-11-22 09:41:21 UTC 
Created attachment 291223 [details] [review]
base-item: Don't scale up thumbnails
Comment 2 Debarshi Ray 2014-11-22 09:44:15 UTC 
Created attachment 291224 [details]
Screenshot - thumbnails with emblems 

When the thumbnails are very small (eg., 96x96) then the emblems become too tiny. We can solve this by imagining a 256x256 grid when placing the emblems, but the question is whether the emblems should be inside or outside the framed shadow?
Comment 3 Allan Day 2014-11-24 12:06:19 UTC 
(In reply to comment #2)
> Created an attachment (id=291224) [details]
> Screenshot - thumbnails with emblems 
> 
> When the thumbnails are very small (eg., 96x96) then the emblems become too
> tiny. We can solve this by imagining a 256x256 grid when placing the emblems,
> but the question is whether the emblems should be inside or outside the framed
> shadow?

My suggestion - place the emblem inside the grid, but don't scale it down. Not sure how hard that is...
Comment 4 Debarshi Ray 2014-11-25 14:31:35 UTC 
Created attachment 291463 [details] [review]
base-item, utils: Don't scale up thumbnails (v2)
Comment 5 Debarshi Ray 2014-11-25 14:32:19 UTC 
Created attachment 291464 [details]
Screenshot - thumbnails with emblems (v2)
Comment 6 Debarshi Ray 2014-11-25 14:35:01 UTC 
You need the patch from bug 709362 before applying this one.
Comment 7 Debarshi Ray 2014-11-28 11:10:28 UTC 
Created attachment 291713 [details] [review]
base-item, utils: Don't scale up thumbnails
Comment 8 Debarshi Ray 2014-11-28 11:13:21 UTC 
I am pushing the first version of the patch for the moment. If we want to handle small images with thumbnails in a better way, we can iterate further.
Comment 9 Debarshi Ray 2017-03-02 07:25:56 UTC 
Review of attachment 291463 [details] [review]:

The leftovers from this patch was rebased and used in bug 777869