GNOME Bugzilla – Bug 709362
use a more subtle image for when loading thumbnail
Last modified: 2014-11-27 10:53:59 UTC
The final thumbnail view is awesome in Photos, but before we get there, the generic image fullcolor icon is shown. When repeated on the grid it takes focus away from the actual thumbnails and doesn't look right. Recently content-loading-symbolic has been created and it's a perfect fit here I think. I'd use it centered at only 16x16px.
Agree that this would be a big improvement when loading photos - which is common if you have a large collection, either locally or online accounts. Setting as a 3.16 target, as this bug is quite obvious for a lot of users.
*** Bug 739813 has been marked as a duplicate of this bug. ***
Created attachment 291228 [details] [review] base-item, utils: Use a more subtle image when loading the thumbnail Questions / thoughts: Maybe we should fallback to the generic image full-colour icon if we failed to create the thumbnail? I wouldn't expect too many of these to happen, so it might be OK in that case. The album icons become completely black until the thumbnail has been created. Do you want a 256x256 shadow around the "content-loading-symbolic" icons?
No shadow and the icon definitely shouldn't scale to 256px. The max size is 16x16. If I recall correctly, Videos has this implemented. https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/videos/videos-loading-thumbnails.png If you fail to generate a thumbnail, use the same 16x16 sized watermark but use image-x-generic-symbolic.
Created attachment 291453 [details] [review] base-item, utils: Use subtler images for loading and failure How about this? Remember to 'rm -rf ~/.cache/thumbnails/' before testing this.
Created attachment 291557 [details] [review] base-item, utils: Use subtler images for loading and failure (v2)
Created attachment 291579 [details] [review] base-item, utils: Use subtler images for loading and failure Jimmac, can you please try this?
Review of attachment 291579 [details] [review]: Looking good.
Created attachment 291627 [details] [review] base-item, utils: Use subtler images for loading and failure Thanks for taking a look, jimmac. Committed after a trivial fixup.