After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 740332 - Gedit external tools plugin fails to save documents (exact cause included)
Gedit external tools plugin fails to save documents (exact cause included)
Status: RESOLVED DUPLICATE of bug 739686
Product: gedit-plugins
Classification: Other
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-11-18 17:01 UTC by toberrrt
Modified: 2019-03-23 20:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description toberrrt 2014-11-18 17:01:18 UTC 
Occurence: On calling an external tools-command with the "save" option set to either 'document' or 'all documents'

Expected behaviour: The plugin saves the specified file/s if they're modified and executes the command.

Actual behaviour: If one or more of the specified files are modified, the plugin exits with an error without doing anything.

The error message is as follows:

"Traceback (most recent call last):

+ Trace 234343

  • File "/usr/lib/x86_64-linux-gnu/gedit/plugins/externaltools/functions.py", line 298 in capture_menu_action 
    MultipleDocumentsSaver(window, panel, False, node)
  • File "/usr/lib/x86_64-linux-gnu/gedit/plugins/externaltools/functions.py", line 263 in __init__ 
    signals[doc] = doc.connect('saving', self.on_document_saving)
TypeError: <Document object at 0x7f4cf9b04f30 (GeditDocument at 0x7f4cfc010170)>: unknown signal name: saving" 

Solution: In gedit/plugins/externaltools/functions.py, line 263 (inside class MultipleDocumentSaver) change "signals[doc] = doc.connect('saving', self.on_document_saving)" to "signals[doc] = doc.connect('save', self.on_document_saving)".

Reported on Debian jessie with Gnome 3.14.1
Comment 1 toberrrt 2014-11-18 17:03:31 UTC 
Sorry for the formatting chaos. I cannot repair it since I seem not to be able to edit the bug report.
Comment 2 Sébastien Wilmet 2014-11-18 17:47:37 UTC 
Yes, we are aware of this problem, I've begun working on this, but it requires some more work. It'll hopefully be fixed for the next minor release.

*** This bug has been marked as a duplicate of bug 739686 ***
Comment 3 toberrrt 2014-11-18 22:06:30 UTC 
Well at least there exists a workaround as mentioned above. I think it's better to provide an Class based on a deprecated API than a functionally broken Class.