After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 739686 - Port the external tools plugin to the new GeditDocument API
Port the external tools plugin to the new GeditDocument API
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
: 740332 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-11-05 20:14 UTC by Sébastien Wilmet
Modified: 2019-03-23 20:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sébastien Wilmet 2014-11-05 20:14:23 UTC 
In functions.py, the MultipleDocumentsSaver class must be ported.

The problem is that it can't be ported with the current gedit API, since the error parameter of the "saved" signal is needed.

A cleaner implementation of MultipleDocumentsSaver would be to add and use a new public API in gedit core: gedit_commands_save_document_async() and gedit_commands_save_document_finish(), with a boolean return value for finish() which tells whether the file was correctly saved (and maybe an error parameter too).
Comment 1 Sébastien Wilmet 2014-11-18 17:47:37 UTC 
*** Bug 740332 has been marked as a duplicate of this bug. ***
Comment 2 Sébastien Wilmet 2014-11-19 22:07:43 UTC 
Finished:
https://git.gnome.org/browse/gedit/log/?h=wip/fix-external-tools

A review would be better, since it adds a new API to gedit.
Comment 3 Sébastien Wilmet 2014-11-29 16:40:18 UTC 
I've pushed the commits, it was quite important.