Bug 738767 – pitivi uses GdkX11 module directly

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 738767 - pitivi uses GdkX11 module directly


Summary:	pitivi uses GdkX11 module directly


Status:	RESOLVED FIXED

Product:	pitivi
Classification:	Other
Component:	General
Version:	Git
Hardware:	Other Mac OS

Importance:	Normal normal
Target Milestone:	0.94
Assigned To:	Pitivi maintainers
QA Contact:	Pitivi maintainers

URL:
Whiteboard:

Depends on:	688830
Blocks:	738622 738771

Reported:	2014-10-18 14:39 UTC by Brion Vibber
Modified:	2014-11-07 04:57 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Quick hack to load GdkX11 in a try block (2.19 KB, patch) 2014-10-18 16:38 UTC, Brion Vibber	committed	Details \| Review

Description Brion Vibber 2014-10-18 14:39:39 UTC

I managed to get pitivi to build on Mac OS X 10.9.5 (build issues tracked via bug 738622), but it doesn't run because there's an explicit usage of the GdkX11 module:

ERROR:root:Could not find any typelib for GdkX11
Failed to initialize modules
Traceback (most recent call last):

+ Trace 234234

File "/Users/brion/cerbero/dist/darwin_x86_64/bin/pitivi", line 132 in <module>
```
_initialize_modules()
```
File "/Users/brion/cerbero/dist/darwin_x86_64/bin/pitivi", line 112 in _initialize_modules
```
initialize_modules()
```
File "/Users/brion/cerbero/dist/darwin_x86_64/lib/pitivi/python/pitivi/check.py", line 271 in initialize_modules
```
from gi.repository import GdkX11
```

ImportError: cannot import name 'GdkX11'



This could be a problem for running natively on Wayland as well.


It looks like the GdkX11 module is used only for this in application.py:

        if self.gui:
            # The app is already started and the window already created.
            # Present the already existing window.
            # TODO: Use present() instead of present_with_time() when
            # https://bugzilla.gnome.org/show_bug.cgi?id=688830 is fixed.
            x11_server_time = GdkX11.x11_get_server_time(self.gui.get_window())
            self.gui.present_with_time(x11_server_time)
            # No need to show the welcome wizard.
            return

Comment 1 Brion Vibber 2014-10-18 16:38:16 UTC

Created attachment 288815 [details] [review]
Quick hack to load GdkX11 in a try block

Comment 2 Thibault Saunier 2014-10-19 09:22:33 UTC

commit 10d82cd5e13a06616d884d175a81ebcc4daf3880
Author: Brion Vibber <brion@pobox.com>
Date:   Sat Oct 18 09:07:01 2014 -0700

    pitivi: Remove our hard dependency to GdkX11
    
    Allowing us to run without X11, as on Mac OS X