After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738740 - gl/cocoa: Fails to build on Mac OS X 10.10
gl/cocoa: Fails to build on Mac OS X 10.10
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 738622
 
 
Reported: 2014-10-18 04:29 UTC by Brion Vibber
Modified: 2014-10-19 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that fixes build for me on OS X 10.10 (1.41 KB, patch)
2014-10-18 04:29 UTC, Brion Vibber 		committed Details | Review

Description Brion Vibber 2014-10-18 04:29:09 UTC 
Created attachment 288792 [details] [review]
Patch that fixes build for me on OS X 10.10

gst-plugins-bad fails to build on OS X 10.10 with this odd error:

gstglwindow_cocoa.m:141:27: error: sending 'GstGLNSWindow *' to parameter of incompatible type 'id<NSFileManagerDelegate>' [-Werror]
      [NSApp setDelegate: priv->internal_win_id];
                          ^~~~~~~~~~~~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSFileManager.h:109:47: note: passing argument to parameter 'delegate' here
@property (assign) id <NSFileManagerDelegate> delegate NS_AVAILABLE(10_5, 2_0);
                                              ^
1 error generated.


See attached patch for a fix that seems to work on 10.10.
Comment 1 Robert Swain 2014-10-19 16:50:57 UTC 
I hit this too.
Comment 2 Robert Swain 2014-10-19 17:03:31 UTC 
Also, the patch builds for me and makes sense.
Comment 3 Sebastian Dröge (slomo) 2014-10-19 18:02:31 UTC 
commit 88b19bcf997b0f396737af5b5fc2fd9a3a9957eb
Author: Brion Vibber <brion@pobox.com>
Date:   Fri Oct 17 21:26:52 2014 -0700

    gl/cocoa: Fix for building on Mac OS X 10.10
    
    Using NSApp directly seems to confuse something, as the compiler
    was expecting an id<NSFileManagerDelegate>. Switched to using
    [NSApplication sharedApplication], and specified the delegate
    protocol on the window class as well.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738740