GNOME Bugzilla – Bug 738673
[nautilus] 3.14 Desktop is rendered even if shouldn't
Last modified: 2015-08-24 15:42:44 UTC
Since version 3.14, nautilus draws the desktop icons when it's launched, even if another desktop manager (caja, nemo) already drew it. It shows the following message on console output: ** (nautilus:2620): CRITICAL **: Another desktop manager in use; desktop window won't be created
Which distribution is this about? Do you have the option of desktop managing icons activated? Is so, can you try again deactivating it?
Distribution is Arch Linux. And the desktop icons are enabled: $ gsettings set org.gnome.desktop.background show-desktop-icons true But nautilus shouldn't draw the desktop icons if another desktop manager already drew it, even if it's enabled. It's a regression in nautilus 3.14.
Disabling `show desktop icons` makes the issue disappear. However, it is not supposed to happen even when it's enabled. Another issue I noticed is that when I deactivate the `show desktop icons` option, the desktop background is reset to default.
Still happens with nautilus 3.14.2.
Still happens with nautilus 3.16.2.
Created attachment 308175 [details] [review] [PATCH] Don't draw the desktop if another desktop manager in use I created a patch that fixes the problem. Please apply it for master, gnome-3-16 and gnome-3-14 branches.
Tell me if it is not a duplicate and if it doesnt work for you. As said in the duplicated, use the --no-desktop if you want to override programatically. *** This bug has been marked as a duplicate of bug 750528 ***
No, it doesn't work for me, it's a different problem. Nautilus detects if another desktop manager is in use: https://git.gnome.org/browse/nautilus/tree/src/nautilus-desktop-window.c#n135 But later, this detection is ignored, and Nautilus draw the desktop anyway. It's a regression introduced by this commit: https://git.gnome.org/browse/nautilus/commit/?id=3eeda743a42fe10f0e31743c3fb2ba8907fc8883 This condition was respected in the old code: https://git.gnome.org/browse/nautilus/tree/src/nautilus-application.c?id=89412e0439757547b384c7b802801d1221b28bb8#n463 But missing from the new code: https://git.gnome.org/browse/nautilus/tree/src/nautilus-desktop-window.c#n189 My patch simply adds this condition back, and Nautilus respects it again.
Review of attachment 308175 [details] [review]: This looks good to me, thanks for the patch!
Pushed to master.