GNOME Bugzilla – Bug 738035
mpegtsdemux : Add SMPTE registered KLV in private PES packets support
Last modified: 2018-11-03 13:27:21 UTC
Apply first : https://bugzilla.gnome.org/show_bug.cgi?id=738034
Created attachment 287886 [details] [review] KLV into private PES packets
Created attachment 287946 [details] [review] KLV support for mpeg-ts For what it's worth, I'm working on KLV support in mpeg-ts (and RTP) as well. I think my tsdemux patch for this might be somewhere else in bugzilla already, but I'm attaching it here again anyway. I didn't push it yet because there was something I needed to check (there are different ways to embed klv in mpeg-ts).
Both patch seem identical except : - I use the GST_MPEGTS_MAKE_REGISTRATION_FOURCC I introduced into https://bugzilla.gnome.org/show_bug.cgi?id=738033. I think the FOURCC philosophy is better. No ? - I use "application/x-metadata" for the caps with format_identifier set to "KLVA". It is for good compliance with other ways to handle metadata I introduced in https://bugzilla.gnome.org/show_bug.cgi?id=738036. Do you agree with this one ?
Created attachment 288013 [details] [review] Add SMPTE KLV in private PES
(In reply to comment #2) > Created an attachment (id=287946) [details] [review] > KLV support for mpeg-ts > > For what it's worth, I'm working on KLV support in mpeg-ts (and RTP) as well. I > think my tsdemux patch for this might be somewhere else in bugzilla already, > but I'm attaching it here again anyway. I didn't push it yet because there was > something I needed to check (there are different ways to embed klv in mpeg-ts). Do you have a patch for RTP KLV support ?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/179.