GNOME Bugzilla – Bug 738033
mpegts : add new descriptors and cleanup
Last modified: 2018-11-03 13:27:05 UTC
Some cleanup to better follow specifications Numerous descriptors added like metadata Split some files and clean them Should apply to 1.5 branch without problem Any reviewer ?
Created attachment 287884 [details] [review] MPEG-TS : new descriptors
This is quite big. Can you split it up in different commits ? Also there are added-but-commented-out lines here and there
Yes quite big. :-) I split it in more commits. Hope it will be good. Forgot previous patch.
Created attachment 288000 [details] [review] 001 - Add ATSC descriptors
Created attachment 288001 [details] [review] 002 - Add ISDB decriptors
Created attachment 288002 [details] [review] 003 - Add Blu-ray sections
Created attachment 288003 [details] [review] 004 - Add HDV sections
Created attachment 288004 [details] [review] 004 - Add ATSC stream types
Created attachment 288005 [details] [review] 006 - Miscellaneous stream types
Created attachment 288006 [details] [review] 007 - Move DVB descriptors
Created attachment 288007 [details] [review] 008 - Add new descriptor into MPEG-TS lib
Created attachment 288008 [details] [review] 009 - Add registration descriptor parsing
Created attachment 288009 [details] [review] 010 - Add metadata descriptors
Created attachment 288010 [details] [review] 011 - Add FOURCC registration helpers
Someone to review and push it into master ? :-)
The patches don't apply cleanly on master -bad. Can you re-check and re-provide ? If you have a public git repository, that's fine also.
(In reply to comment #16) > The patches don't apply cleanly on master -bad. Can you re-check and re-provide > ? If you have a public git repository, that's fine also. Hello, sorry for the problems. I put everything on gitorious : https://gitorious.org/gstreamer-chamois94/gst-plugins-bad/
Can you make a branch for commits that concern just this bug ? Each commit message should also contain a reference to this bug: https://bugzilla.gnome.org/show_bug.cgi?id=738033
(In reply to comment #18) > Can you make a branch for commits that concern just this bug ? Each commit > message should also contain a reference to this bug: > https://bugzilla.gnome.org/show_bug.cgi?id=738033 Done ! Branch : bugzilla_738033 https://gitorious.org/gstreamer-chamois94/gst-plugins-bad/source/db6b92643088bda7f0f5539e19ad83e8906ec25b:
A few comments: * Please put your email address (alongside your name) in the headers * Some of this code was just moved from other files, please include the original authors in the headers * For the new descriptor parsing you've added, could you also add the corresponding support in tests/examples/mpegts/ ? This helps to make sure the API is correct. * The various API addition need to be added to the docs (docs/libs/) The enum addition/movement are fine (once licenses are updated), I'll push them once you've updated those.
(In reply to comment #20) > A few comments: > > * Please put your email address (alongside your name) in the headers > * Some of this code was just moved from other files, please include the > original authors in the headers > * For the new descriptor parsing you've added, could you also add the > corresponding support in tests/examples/mpegts/ ? This helps to make sure the > API is correct. > * The various API addition need to be added to the docs (docs/libs/) > > The enum addition/movement are fine (once licenses are updated), I'll push them > once you've updated those. Done for the first two points. I'll add unit tests and docs as soon as I have some time.
Is any of this still useful? If yes, it should be clean up, if not, let's close this.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/177.