After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 737233 - right click on the background locks mouse clicks
right click on the background locks mouse clicks
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
3.13.x
Other Linux
: Normal major
: ---
Assigned To: mutter-maint
mutter-maint
3.14.1
: 737496 737882 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-09-24 06:15 UTC by Branko Grubic (bitlord)
Modified: 2014-10-05 04:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
test-runner: make test_case_wait() wait for queued-work (2.38 KB, patch)
2014-09-24 20:26 UTC, Owen Taylor
committed Details | Review
test-runner: represent the guard window as '|' for assert_stacking (3.03 KB, patch)
2014-09-24 20:26 UTC, Owen Taylor
committed Details | Review
tests: Add minimize/unminimize commands (2.94 KB, patch)
2014-09-24 20:26 UTC, Owen Taylor
committed Details | Review
Add a test for stacking vs. minimization (1.34 KB, patch)
2014-09-24 20:26 UTC, Owen Taylor
reviewed Details | Review
Fix stacking of the guard window (1.59 KB, patch)
2014-09-24 20:26 UTC, Owen Taylor
committed Details | Review
Add a test for stacking vs. minimization (1.49 KB, patch)
2014-09-24 20:51 UTC, Owen Taylor
committed Details | Review

Description Branko Grubic (bitlord) 2014-09-24 06:15:28 UTC
I'm using gnome-shell-3.13.92-1.fc21.x86_64 and I wanted to change a background, I know there is a menu available, so I did right click on the background, but nothing happened, so I tried alternative way then, and I realized that mouse clicks are not working anymore, before restarting everything I tried few things, and it worked, ctrl+alt+up/down works changes workspaces, but no mouse clicks, and later I found the workaround, meta key to go to overview mode, and when it is closed everything works again.
Also not sure is this intended, while writing this bug report, I retested it, and looks like left (primary click) opens menu, not right click? But right click still locks mouse clicks.

Not sure can this be related, but background which set up before I wanted to change it was "animated"/time_changing default background for gnome.
Comment 1 Owen Taylor 2014-09-24 20:26:21 UTC
Created attachment 287005 [details] [review]
test-runner: make test_case_wait() wait for queued-work

Sometimes (for example with minimization) a request from the client
causes queued work rather than immediate work; so make the test client
'wait' command wait for a full frame cycle.
Comment 2 Owen Taylor 2014-09-24 20:26:27 UTC
Created attachment 287006 [details] [review]
test-runner: represent the guard window as '|' for assert_stacking

Allow putting '|' into the list of windows for assert_stacking to
represent the position of the guard window. Not present is the same
as at the beginning (bottom) of the list.
Comment 3 Owen Taylor 2014-09-24 20:26:31 UTC
Created attachment 287007 [details] [review]
tests: Add minimize/unminimize commands

Add commands to request the client to minimize or unminimize the window;
unminimize doesn't currently work for GTK+ because it expects XMapRequest
to be received by the window manager, but the window is already mapped.
Comment 4 Owen Taylor 2014-09-24 20:26:36 UTC
Created attachment 287008 [details] [review]
Add a test for stacking vs. minimization

Test that the guard window is in the right place.
Comment 5 Owen Taylor 2014-09-24 20:26:41 UTC
Created attachment 287009 [details] [review]
Fix stacking of the guard window

With the change to how hidden windows are stacked, the position
of the guard window with respect to the hidden windows got flipped
and the guard window was at the bottom of everything; fix it to
be on top of the hidden windows.
Comment 6 Florian Müllner 2014-09-24 20:39:27 UTC
Review of attachment 287009 [details] [review]:

Yes.
Comment 7 Florian Müllner 2014-09-24 20:40:17 UTC
Review of attachment 287007 [details] [review]:

Sure
Comment 8 Florian Müllner 2014-09-24 20:40:44 UTC
Review of attachment 287008 [details] [review]:

::: src/tests/stacking/minimized.metatest
@@ +11,3 @@
+assert_stacking 1/2 | 1/1
+
+activate 1/2

Not unminimized?
Comment 9 Florian Müllner 2014-09-24 20:48:14 UTC
Review of attachment 287006 [details] [review]:

OK
Comment 10 Owen Taylor 2014-09-24 20:48:38 UTC
(In reply to comment #8)
> Review of attachment 287008 [details] [review]:
> 
> ::: src/tests/stacking/minimized.metatest
> @@ +11,3 @@
> +assert_stacking 1/2 | 1/1
> +
> +activate 1/2
> 
> Not unminimized?

This is mentioned in the commit message, but I should probably have a comment here:

    Add commands to request the client to minimize or unminimize the window;
    unminimize doesn't currently work for GTK+ because it expects XMapRequest
    to be received by the window manager, but the window is already mapped.

activate works fine.

(I don't want this to be XFAIL because a) I don't have that in the test framework b) I want to actually test the stacking part.)
Comment 11 Owen Taylor 2014-09-24 20:51:47 UTC
Created attachment 287014 [details] [review]
Add a test for stacking vs. minimization

Test that the guard window is in the right place.
Comment 12 Florian Müllner 2014-09-24 20:52:23 UTC
Review of attachment 287005 [details] [review]:

OK
Comment 13 Owen Taylor 2014-09-24 20:54:23 UTC
Attachment 287005 [details] pushed as 74c37d4 - test-runner: make test_case_wait() wait for queued-work
Attachment 287006 [details] pushed as 7616881 - test-runner: represent the guard window as '|' for assert_stacking
Attachment 287007 [details] pushed as 371560c - tests: Add minimize/unminimize commands
Attachment 287009 [details] pushed as d3111a9 - Fix stacking of the guard window
Attachment 287014 [details] pushed as cdfb301 - Add a test for stacking vs. minimization
Comment 14 Florian Müllner 2014-09-24 20:56:24 UTC
Review of attachment 287014 [details] [review]:

Uhm, sorry - the code in the patch that mentioned the GTK+ issue was so obvious that I didn't really read the commit message :-(
Comment 15 Jasper St. Pierre (not reading bugmail) 2014-09-30 15:48:58 UTC
*** Bug 737496 has been marked as a duplicate of this bug. ***
Comment 16 Adam Williamson 2014-10-04 17:52:35 UTC
I've done a backport build of the fix for F21 - https://admin.fedoraproject.org/updates/mutter-3.14.0-3.fc21 .
Comment 17 Jasper St. Pierre (not reading bugmail) 2014-10-05 04:14:57 UTC
*** Bug 737882 has been marked as a duplicate of this bug. ***