After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736885 - App folder - apps out of bounds still visible during animation
App folder - apps out of bounds still visible during animation
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: overview
3.13.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 737462 738174 738261 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-09-18 11:44 UTC by Mantas Mikulėnas (grawity)
Modified: 2014-10-09 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screencast (1.31 MB, video/webm)
2014-09-18 11:47 UTC, Mantas Mikulėnas (grawity) 		  Details
iconGrid: Don't use clones for pulse animation (3.38 KB, patch)
2014-09-18 12:48 UTC, Florian Müllner 		committed Details | Review

Description Mantas Mikulėnas (grawity) 2014-09-18 11:44:42 UTC 
The app folders can show up to 3 lines of apps. If a folder has more than that, then apps in lines 4+ are normally only visible when scrolling. However, after the recent animations addition, those apps are visible during the folder-open animation, and disappear only afterwards. See video.
Comment 1 Mantas Mikulėnas (grawity) 2014-09-18 11:47:49 UTC 
Created attachment 286480 [details]
screencast
Comment 2 Florian Müllner 2014-09-18 12:48:28 UTC 
Created attachment 286490 [details] [review]
iconGrid: Don't use clones for pulse animation

The spring animation has to use clones to escape any clip set on the
parent, as it mainly occurs outside the parent. The same does not apply
to the pulse animation, which is very much in place - in fact, if the
parent is clipped (for instance a scrolled app folder), not having the
clip applied to the animated icons is indeed wrong.
Just animate the original grid actors instead, which gives the expected
result.
Comment 3 Carlos Soriano 2014-09-19 15:53:20 UTC 
Review of attachment 286490 [details] [review]:

OK
Comment 4 Florian Müllner 2014-09-22 18:54:40 UTC 
Attachment 286490 [details] pushed as 63efe1d - iconGrid: Don't use clones for pulse animation
Comment 5 Florian Müllner 2014-09-26 20:42:09 UTC 
*** Bug 737462 has been marked as a duplicate of this bug. ***
Comment 6 Florian Müllner 2014-10-08 20:54:29 UTC 
*** Bug 738174 has been marked as a duplicate of this bug. ***
Comment 7 Florian Müllner 2014-10-09 20:15:35 UTC 
*** Bug 738261 has been marked as a duplicate of this bug. ***