After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736741 - Update private copy of valgrind.h
Update private copy of valgrind.h
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-09-16 12:09 UTC by Debarshi Ray
Modified: 2018-05-08 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
glib: Update internal copy of valgrind.h from Valgrind 3.13 release (67.41 KB, patch)
2018-04-23 11:33 UTC, Philip Withnall
committed Details | Review

Description Debarshi Ray 2014-09-16 12:09:27 UTC
From https://bugzilla.redhat.com/show_bug.cgi?id=1141471

"This package appears to include a private copy of valgrind.h. In the latest relase of valgrind 3.10.0 a bug was fixed for ppc32 and support was added for aarch64 and ppc64le. Please either update the private copy of valgrind.h (memcheck.h, callgrind.h, etc) or (better) make your package BuildRequires: valgrind-devel and use the system installed headers."

The ppc32 bug that was fixed is https://bugs.kde.org/show_bug.cgi?id=278808 , which led to:

commit 6c8600b2b86fe42edd6d6e9648a92f32e404457c
Author: Ryan Lortie <desrt@desrt.ca>
Date:   Wed Nov 20 16:57:26 2013 -0500

    valgrind.h: add "r0" to the clobber list on PPC
    
    Looks like the magic sequences trash this register, so make sure GCC
    knows that.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=710983

... and we should be careful not to stomp over:

commit 72de983469ce1db81134ed3b5e2af77b56170bf3
Author: Chun-wei Fan <fanchunwei@src.gnome.org>
Date:   Mon Jun 30 17:31:57 2014 +0800

    valgrind.h: Disable Valgrind features on x64 Visual C++ Builds
    
    ...so that builds of GLib on x64 Visual C++ can be restored, as the build
    fails in line 449 of valgrind.h as it only supports MinGW/GCC for x64
    Windows and simply will not build otherwise.  Make the x64 Visual C++
    builds compile again by defining NVALGRIND when GLib is being built for
    Windows on x64 Visual C++.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=732465
Comment 1 Allison Karlitskaya (desrt) 2014-09-16 15:31:40 UTC
The cause and effect is backwards: we fixed the ppc32 issue first and then it went upstream.

Might still be nice to get the new support for the other arches, though.
Comment 2 Debarshi Ray 2014-09-16 15:37:49 UTC
(In reply to comment #1)
> The cause and effect is backwards: we fixed the ppc32 issue first and then it
> went upstream.

Yes, I wanted to say "the bug that we fixed has now been fixed upstream". :)
Comment 3 Philip Withnall 2018-04-23 11:33:52 UTC
Created attachment 371269 [details] [review]
glib: Update internal copy of valgrind.h from Valgrind 3.13 release

Update our copy of valgrind.h from the Valgrind 3.13 release tarball.
This seems to include fixes for PPC and Solaris. No changes made to the
header file.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 4 Emmanuele Bassi (:ebassi) 2018-05-08 11:28:26 UTC
Review of attachment 371269 [details] [review]:

Sure
Comment 5 Philip Withnall 2018-05-08 11:38:09 UTC
Attachment 371269 [details] pushed as 864cb71 - glib: Update internal copy of valgrind.h from Valgrind 3.13 release