After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732465 - Fix build on x64 Visual C++ builds
Fix build on x64 Visual C++ builds
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
2.41.x
Other Windows
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-06-30 09:27 UTC by Fan, Chun-wei
Modified: 2014-06-30 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
glib/valgrind.h: Disable valigrind features on x64 Visual C++ builds (1.31 KB, patch)
2014-06-30 09:38 UTC, Fan, Chun-wei 		committed Details | Review

Description Fan, Chun-wei 2014-06-30 09:27:12 UTC 
Hi,

Commit c4fc3aa5 ("valgrind.h: Update to latest upstream version") unfortunately broke the build of GLib on x64 Visual C++ as the latest valgrind.h that is shipped with GLib currently requires the use of inline assembly code for it to be supported.

This, as a result, causes a compiler error (#error Unsupported compiler.) in valgrind.h line 449, when GLib is being built with x64 editions of Visual C++, as x64 Visual C++ does not support the use of inline assembly code.
Comment 1 Fan, Chun-wei 2014-06-30 09:38:27 UTC 
Created attachment 279584 [details] [review]
glib/valgrind.h: Disable valigrind features on x64 Visual C++ builds

Hi,

This is my patch to deal with the issue, until valgrind.h can work with x64 Visual C++ builds, by disabling valgrind features using the macro NVALGRIND on x64 Visual C++ builds.

With blessings, thank you!
Comment 2 Colin Walters 2014-06-30 11:44:30 UTC 
Review of attachment 279584 [details] [review]:

Looks fine, thanks!
Comment 3 Fan, Chun-wei 2014-06-30 12:02:05 UTC 
Hi Colin,

Thanks for the reviews, the patch was pushed as 72de9834.

With blessings!
Comment 4 Allison Karlitskaya (desrt) 2014-06-30 13:11:21 UTC 
Hopefully we don't forget about this next time we upgrade...