After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736147 - Make the search provider work again
Make the search provider work again
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-05 17:56 UTC by Matthias Clasen
Modified: 2014-09-19 21:05 UTC
See Also:
GNOME target: 3.14
GNOME version: ---


Attachments
Make the search provider work again (1.02 KB, patch)
2014-09-05 17:56 UTC, Matthias Clasen
reviewed Details | Review
Make the search provider work again (1.91 KB, patch)
2014-09-19 20:48 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2014-09-05 17:56:18 UTC
gnome-shell complains that it can't load the contacts search
provider because the desktop id doesn't match anything. This
was forgotten when we changed the desktop id to match the
bus name.
Comment 1 Matthias Clasen 2014-09-05 17:56:21 UTC
Created attachment 285512 [details] [review]
Make the search provider work again
Comment 2 Erick Perez Castellanos 2014-09-05 18:48:12 UTC
(In reply to comment #1)
> Created an attachment (id=285512) [details] [review]
> Make the search provider work again

Does this make the search work? or is it more work required. I have some patches lying around in my dev environment about this, I want to test
Comment 3 Matthias Clasen 2014-09-05 18:52:27 UTC
I have to admit that I haven't tested the search provider, this patch is purely based on the gnome-shell error message that I found in my logs.
Comment 4 Erick Perez Castellanos 2014-09-19 15:19:47 UTC
Review of attachment 285512 [details] [review]:

This is accepted. It's just that I would like to commit it after the one in bug 685227.
Comment 5 Matthias Clasen 2014-09-19 20:48:47 UTC
Created attachment 286659 [details] [review]
Make the search provider work again

gnome-shell complains that it can't load the contacts search
provider because the desktop id doesn't match anything. This
was forgotten when we changed the desktop id to match the
bus name.
Comment 6 Matthias Clasen 2014-09-19 20:49:55 UTC
turns out that the patch I tested had additionally renamed the search-provider .ini file, and this is actually necessary to make things work. Thats the only additional change in the new patch.
Comment 7 Erick Perez Castellanos 2014-09-19 21:04:54 UTC
Review of attachment 286659 [details] [review]:

Good to go. Committed
Comment 8 Erick Perez Castellanos 2014-09-19 21:05:58 UTC
Fixed in master