After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736065 - Improve the message for Incognito mode
Improve the message for Incognito mode
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-09-04 15:43 UTC by Emmanuele Bassi (:ebassi)
Modified: 2014-09-05 13:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Improve the message for Incognito mode (1.53 KB, patch)
2014-09-04 15:43 UTC, Emmanuele Bassi (:ebassi)
reviewed Details | Review
Improve the message for Incognito mode / v2 (2.02 KB, patch)
2014-09-05 11:06 UTC, Emmanuele Bassi (:ebassi)
none Details | Review
Improve the message for Incognito mode / v3 (2.04 KB, patch)
2014-09-05 11:08 UTC, Emmanuele Bassi (:ebassi)
none Details | Review
Improve the message for Incognito mode (2.00 KB, patch)
2014-09-05 13:53 UTC, Michael Catanzaro
committed Details | Review

Description Emmanuele Bassi (:ebassi) 2014-09-04 15:43:51 UTC
The message emphasis on local activity provides a sense of false security; "incognito mode" does not prevent other actors from
tracking web browsing activity.

We should also consider adding a link to the Tor project.
Comment 1 Emmanuele Bassi (:ebassi) 2014-09-04 15:43:59 UTC
Created attachment 285396 [details] [review]
Improve the message for Incognito mode

Going incognito does not remove your downloads.

Incognito also does not prevent other actors from tracking your browsing
activity.
Comment 2 Michael Catanzaro 2014-09-04 16:35:48 UTC
Review of attachment 285396 [details] [review]:

Definitely.

You might be able to get a string freeze exception for this if you want, since we're only a couple of days into string freeze.

::: embed/ephy-about-handler.c
@@ +543,3 @@
                             "mode will not show up in your browsing history and all stored "
+                            "information will be cleared when you close the window. Any files you "
+                            "download will be kept.\n"

Instead of adding a newline to the string that translators will see, add a second HTML paragraph to the format string above.

@@ +544,3 @@
+                            "information will be cleared when you close the window. Any files you "
+                            "download will be kept.\n"
+                            "It is important to know that browsing in incognito will not hide your "

Instead of "browsing in incognito," I think it'd be more natural to say "browsing in incognito mode" or simply "incognito mode."
Comment 3 André Klapper 2014-09-04 19:46:50 UTC
I'd also appreciate if we tried to get this in for 3.14.
Anybody willing to ask on gnome-i18n@ for two string freeze break approvals?
Comment 4 Claudio Saavedra 2014-09-05 10:57:51 UTC
Review of attachment 285396 [details] [review]:

I agree with the importance of doing this, but I think the text should be added in a different paragraph and with some form of special emphasis to call for attention. Check Firefox and Chrome on this.
Comment 5 Emmanuele Bassi (:ebassi) 2014-09-05 11:06:22 UTC
Created attachment 285479 [details] [review]
Improve the message for Incognito mode / v2

updated after review

 * split into a second paragraph
 * browsing in incognito → incognito mode
Comment 6 Emmanuele Bassi (:ebassi) 2014-09-05 11:08:23 UTC
Created attachment 285481 [details] [review]
Improve the message for Incognito mode / v3

added <strong> around the second paragraph, for emphasis
Comment 7 Emmanuele Bassi (:ebassi) 2014-09-05 11:09:01 UTC
I can send an email to d-d-l and gnome-i18n about this.
Comment 8 Emmanuele Bassi (:ebassi) 2014-09-05 11:12:51 UTC
mail sent: https://mail.gnome.org/archives/desktop-devel-list/2014-September/msg00043.html
Comment 10 Yosef Or Boczko 2014-09-05 12:05:44 UTC
Please, why there is <em>incognito</em> in the string?
Comment 11 Yosef Or Boczko 2014-09-05 12:06:15 UTC
Just for a referense: https://wiki.gnome.org/Initiatives/GnomeGoals/RemoveMarkupInMessages
Comment 12 Emmanuele Bassi (:ebassi) 2014-09-05 12:15:07 UTC
(In reply to comment #10)
> Please, why there is <em>incognito</em> in the string?

it has been there for the past year and a half, since the about:incognito page landed for bug 694200:

commit 4e23859050fd1410820312c16a21b3716d9f08e9
Author: Claudio Saavedra <csaavedra@igalia.com>
Date:   Tue Feb 19 20:26:21 2013 +0200

    ephy-about-handler: add a about:incognito handler
    
    This shows a welcome message for incognito windows.
    Artwork by Jakub Steiner.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=694200

the <em> markup is also deeply embedded into the string, so we cannot just remove it — even the wiki page you link makes a point about a similar case.
Comment 13 Michael Catanzaro 2014-09-05 13:53:16 UTC
Created attachment 285498 [details] [review]
Improve the message for Incognito mode

Tweaked slightly, thanks!
Comment 14 Michael Catanzaro 2014-09-05 13:53:43 UTC
Attachment 285498 [details] pushed as 26ab123 - Improve the message for Incognito mode