Created attachment 236813 [details] [review]
ephy-about-handler: add a about:incognito handler

This shows a welcome message for incognito windows.

Created attachment 236814 [details] [review]
incognito: show about:incognito instead of the overview

The overview shouldn't be shown in an incognito window as it reveals
information about the browsing activity of the user. Also, a welcome
page indicating the scope of the incognito window is better.

The text needs to be improved, and also the css, but this does for now.

Review of attachment 236813 [details] [review]:

::: embed/ephy-about-handler.c
@@ +253,3 @@
+                          _("You have opened Web in incognito mode. Pages visited in this mode will not be stored "
+                            "in your history and, once you close this window, all cookies will be forgotten. Be aware "
+                            "of any malicious website, though, as we cannot prevent them from tracking your online activity."));

Just tried this, obviously needs some work. Ideally I'd land it in a more finished state before UI freeze, and specifically I'd not make people translate the string if we are going to change it. So maybe ping peolpe in #gnome-design about it?

Review of attachment 236814 [details] [review]:

::: src/ephy-window.c
@@ -2791,3 @@
-	g_signal_connect_object (overview, "open-link",
-				 G_CALLBACK (overview_open_link_cb),
-				 window, 0);

I think it makes more sense to just not do this in incognito mode, for consistency's sake.

@@ -2880,3 @@
-	g_signal_handlers_disconnect_by_func (overview,
-					      G_CALLBACK (overview_open_link_cb),
-					      window);

Same.

(In reply to comment #3)
 
> Just tried this, obviously needs some work. Ideally I'd land it in a more
> finished state before UI freeze, and specifically I'd not make people translate
> the string if we are going to change it. So maybe ping peolpe in #gnome-design
> about it?

I think we should polish it yes. I added Jon to the CC, he is our hero :)

*** Bug 690340 has been marked as a duplicate of this bug. ***

We need to get this through asap, we can't wait forever until we get some design.  Leaving the overview in incognito mode for 3.8 is plainly wrong and goes against the idea of this mode. So if we don't get any feedback from the design team I'll just land it as is before the next release.

Created attachment 237694 [details] [review]
ephy-about-handler: add a about:incognito handler

This shows a welcome message for incognito windows.

Created attachment 237695 [details] [review]
incognito: show about:incognito instead of the overview

The overview shouldn't be shown in an incognito window as it reveals
information about the browsing activity of the user. Also, a welcome
page indicating the scope of the incognito window is better.

I added the artwork by Jakub and tweaked the css to match his design. Should look better now.

Review of attachment 237694 [details] [review]:

::: data/pages/about.css
@@ +144,3 @@
+.incognito-body div#mainblock {
+  display: table;
+  max-width: 30em;

this looks really narrow in my laptop, but it could be just me. I guess we can tweak it later...

Review of attachment 237695 [details] [review]:

lgtm

Remember you need to ask for permission before landing these.

Got permission from RT, fixed a few minor details and pushed.


Attachment 237694 [details] pushed as 4e23859 - ephy-about-handler: add a about:incognito handler
Attachment 237695 [details] pushed as 0b67bd0 - incognito: show about:incognito instead of the overview