GNOME Bugzilla – Bug 735045
Stopping/deletion of machine should destroy its window
Last modified: 2016-03-31 13:22:07 UTC
If a machine running in a secondary window is destroyed or stopped, Boxes should automatically destroy the window.
Created attachment 285423 [details] [review] app-window: Turn current_item into property We need this to be able to (un)hook on current item's state changes. Not using automatic properties cause we need to do that from setter.
Created attachment 285424 [details] [review] app-window: Close on machine stopping If current machine changes state to a non-running state and window is not main, close the window.
Created attachment 285425 [details] [review] machine: Turn 'deleted' into a property This is so that we can easily listen to a machine (of interest) getting deleted from other modules.
Created attachment 285426 [details] [review] app-window: Close on machine deletion If current machine is deleted and window is not main, close the window.
Pusing these fixes already. Feel free to do a review still. Attachment 285423 [details] pushed as 3a7e28c - app-window: Turn current_item into property Attachment 285424 [details] pushed as 054039f - app-window: Close on machine stopping Attachment 285425 [details] pushed as 353bdee - machine: Turn 'deleted' into a property Attachment 285426 [details] pushed as 560b801 - app-window: Close on machine deletion
*** Bug 736095 has been marked as a duplicate of this bug. ***
Hi all, it works quite well, except of two errors shown if on liveCD (cannot connect to Live box box was deleted automatically), we should probably create some hierarchical (not layered) notifications to avoid this. New bug report? The question is if both should be shown or just the most critical one. Anyway, Cannot connect to.. is probably a bug here)
(In reply to comment #7) > Hi all, > it works quite well, except of two errors shown if on liveCD (cannot connect to > Live box box was deleted automatically), For the record (if anyone reading isn't too familiar with Boxes), the two errors are "Can not connect to %s" and "Live box %s was deleted automatically. [Undo]" >we should probably create some > hierarchical (not layered) notifications to avoid this. AFAIK, they already are hierarchical. Is the issue that you get both notifications at the same time? You shouldn't be getting "Cannot connect to %s" one. Thats a bug in spice: https://bugs.freedesktop.org/show_bug.cgi?id=83692