GNOME Bugzilla – Bug 734064
[regression] scrollToPlayhead does not occur on zoom change with the slider anymore
Last modified: 2014-10-09 02:08:27 UTC
When changing zoom levels and the playhead is in view, scrollToPlayhead should be called to ensure the playhead stays centered. This used to work fine, but now it seems it was lost, I'm not sure when (bisecting 0.93+ is almost impossible). My hunch is commit a0b86d82cbc9de4a17232e440349bfe036c1c024 Author: Alexandru Băluț <alexandru.balut@gmail.com> Date: Sat Feb 15 06:50:44 2014 +0100 widgets: Simplify the zoom controls logic
Actually, this does not affect changing zoom with the mousewheel or keyboard shortcuts, so it is indeed commit a0b86d, as the extended commit msg mentions: > - Removed the timeline._scrollToPlayhead() because it does not make > sense to do that when the zoom level is changed. No, it *must* scrollToPlayhead on zoom change: - This is what keeps the playhead centered and maintains the visual context for users. Otherwise, currently you go somewhere in your timeline, use the slider, and boom, your view is always reset to the very beginning of the timeline, which makes no sense. And then you need to scroll manually to find your playhead, which is nearly impossible at high zoom levels. - We need to be consistent with the keyboard shortcuts' behavior.
I did not understand that bug, Jeff, could you please go and fix it? It seems to be the last one before we can release 0.94.
From testing, Aleb's proposed one-liner fix here fixes the issue (great!): https://github.com/aleb/pitivi/commit/0614710d20a2 Bug #719348 remains quite visible but that's something else entirely.
commit c5a28e958dc55074eef61653d62d5da571ae4c2f Author: Alexandru Băluț <alexandru.balut@gmail.com> Date: Wed Oct 1 20:05:29 2014 +0200 timeline: Scroll to playhead when the zoom changes Fixes https://bugzilla.gnome.org/show_bug.cgi?id=734064