GNOME Bugzilla – Bug 730158
Properties page goes beyond screen in maximized state
Last modified: 2016-03-31 13:22:07 UTC
It's impossible for me to use to the Force Shutdown button on my 1366x768 monitor because it is positioned beneath the bottom of my screen. This is a regression from 3.10. This is not fully reproducible: it seems to happen about half the time. I'm not sure why.
(In reply to comment #0) > It's impossible for me to use to the Force Shutdown button on my 1366x768 > monitor because it is positioned beneath the bottom of my screen. This is a > regression from 3.10. > > This is not fully reproducible: it seems to happen about half the time. I'm not > sure why. I know why :) It only happens if you go to properties from VM display in fullscreen. Its on my TODO already but thanks for putting it in a bug.
(In reply to comment #1) > I know why :) It only happens if you go to properties from VM display in > fullscreen. I initially thought so as well, but in fact the button is sometimes present when I enter from fullscreen mode, and sometimes missing when I was not in fullscreen mode.
(In reply to comment #2) > (In reply to comment #1) > > I know why :) It only happens if you go to properties from VM display in > > fullscreen. > > I initially thought so as well, but in fact the button is sometimes present > when I enter from fullscreen mode, and sometimes missing when I was not in > fullscreen mode. Are you sure? Before 3.12.2, going back to display from properties would enter fullscreen automatically so if you go back and forth between these two states twice in a row when maximaized, that means display is in fullscreen mode.
(In reply to comment #3) > Are you sure? Before 3.12.2, going back to display from properties would enter > fullscreen automatically so if you go back and forth between these two states > twice in a row when maximaized, that means display is in fullscreen mode. Unfortunately, yes I'm sure. (I'm actually using 3.12.2 anyway.)
I tried to trace this for a good number of hours but I failed. I was now even able to reproduce the issue when going to properties in non-fullscreen mode. :( Making the GtkStack (below_bin widget) holding props, display and wizard, homogenous helps for some reason here but that means revival of bug#720908. I could really use the help of some gtk+ guru here. :)
I think it would be useful to log the various async events that are going on here: app requests going !fullscreen app requests going maximized state changes to !fullscreen state changes to maximized wm sets workarea
Created attachment 276798 [details] [review] spice-display: PROPERTIES shouldn't unset resize-guest Don't unset 'resize-guest' property of Spice.Display when going to properties view as its not just redundant but also makes the display grow or shrink to fit guest resolution, which could easily go beyond the screen even. We don't want our window to grow or shrink on its own and especially to grow beyond the screen. If user was able to set a particular size on the window, Boxes must not change it on its own as that would be contrary to what user expects. This issue didn't realize before commit 1854c96, where we made the GtkStack holding most of the views, homogenous.
Attachment 276798 [details] pushed as b56913d - spice-display: PROPERTIES shouldn't unset resize-guest
Thanks Zeeshan -- this one was particularly annoying, and it sounds like it wasn't easy to fix.