After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720908 - Inconsistent windowing behavior in wizard when not maximized
Inconsistent windowing behavior in wizard when not maximized
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: wizard
3.12.x
Other Linux
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-12-21 23:00 UTC by Gabriel Bauman
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
app-window: Make content stack, homogeneous (1.07 KB, patch)
2014-03-26 00:15 UTC, Zeeshan Ali
none Details | Review
wizard: Reduce vertical margins (1.67 KB, patch)
2014-03-26 00:15 UTC, Zeeshan Ali
committed Details | Review
wizard-source: Show 4 medias on short screens (1.06 KB, patch)
2014-03-26 00:15 UTC, Zeeshan Ali
committed Details | Review
screenshot #1 (283.03 KB, image/png)
2014-03-26 10:42 UTC, Christophe Fergeau
  Details
screenshot #2 (252.35 KB, image/png)
2014-03-26 10:44 UTC, Christophe Fergeau
  Details
app-window: Make stacks, homogeneous (1.72 KB, patch)
2014-03-26 13:22 UTC, Zeeshan Ali
committed Details | Review
wizard: Put some margin on the left & right (2.71 KB, patch)
2014-03-26 13:22 UTC, Zeeshan Ali
committed Details | Review

Description Gabriel Bauman 2013-12-21 23:00:41 UTC
When I click "New" to create a new Box with Boxes not maximized:

- the window suddenly expands vertically past the bottom of my screen. There is no obvious reason why it needs so much space.

- the window can not longer be manually resized to fit the screen as long as  the New Box wizard is active. 

- Dragging the window upwards does *not* maximize the window as it should as long as the New Box wizard is showing. Instead, the window's header bar gets stuck behind the Gnome Shell top bar, which hides the wizard's control buttons. Gah!

If I maximize Boxes, then start the New Box wizard, everything works as expected. But if I drag the top bar down to unmaximize the window, we're back to square one.

Steps to reproduce:

1. Start Boxes and unmaximize the window.
2. Click "New" and watch the window expand vertically.
3. Try to resize the window (you can't!)
4. Try to maximize the window by dragging it to the top of the screen.

Alternately,

5. Start Boxes full-screen.
6. Click New.
7. Drag the window header down to unmaximize Boxes.
4. See #3

This is really annoying on low-dpi laptops (1440x900)
Comment 1 Lasse Schuirmann 2014-03-13 13:03:04 UTC
I can't recreate your issue here. (Neither with HEAD 936573f32a2cdbc3db30ade088316eb15d34d76b, nor with gnome-boxes 3.10.2, tried it out on two ArchLinux machines)

It sounds like you're having this issue with several machines. Can you provide more info about what version you are using? Maybe G_MESSAGES_DEBUG=Boxes gnome-boxes puts out something useful on the log if you recreate the situation then.
Comment 2 Christophe Fergeau 2014-03-13 13:46:02 UTC
1) Start Boxes
2) Reduce the window height (make it so only 1 row of VMs is shown)
3) Click on "New"
-> window size changes, and can't be made smaller

My understanding is that it's caused by the widget at the "Source Selection" step, the window minimal size is changed so that this whole page fits without scrollbars.
Comment 3 Gabriel Bauman 2014-03-14 03:24:44 UTC
Hmm. Using the 3.10.2 in Fedora 20, this is no longer an issue for me. Everything works as expected.

Christophe, I take it you are seeing the same behaviour I was seeing when I filed this bug. Which version are you using?
Comment 4 Christophe Fergeau 2014-03-14 09:26:37 UTC
gnome-boxes-3.10.2-2.fc20.x86_64
Do you have some ISOs listed in the "Source Selection" wizard screen?
Comment 5 Zeeshan Ali 2014-03-14 13:45:18 UTC
So what is the main issue we are tracking now?

* wizard expands the window?
* window goes beyond screen? If so, is this specific to small screens?
Comment 6 Christophe Fergeau 2014-03-25 15:21:29 UTC
Main issue from my point of view is that Boxes expands the window, one of the undesirable side-effects being that this expanded window does not fit on small screens.
Comment 7 Zeeshan Ali 2014-03-25 15:41:13 UTC
(In reply to comment #6)
> Main issue from my point of view is that Boxes expands the window,

The simple solution from back of my head is making the GtkStack homogeneous but that won't help with the side-effect below.

> one of the
> undesirable side-effects being that this expanded window does not fit on small
> screens.

How small we are talking about? I just did a quick check and min window size for wizard seems to be 191x850. I don't think we need to support all screen resolutions but 850 is too high a requirement for height I think. I guess we can look into tweaking some margins to get it under 700 (which IMO shouldn't be too high a requirement).
Comment 8 Christophe Fergeau 2014-03-25 16:01:17 UTC
(In reply to comment #7)
> How small we are talking about? I just did a quick check and min window size
> for wizard seems to be 191x850. I don't think we need to support all screen
> resolutions but 850 is too high a requirement for height I think. I guess we
> can look into tweaking some margins to get it under 700 (which IMO shouldn't be
> too high a requirement).

My x201 has a 1280x800 resolution, the much newer x240 has a 1366x768 resolution :-/ 1366x768 is also the resolution of the 11" macbook air. 650/700 of total window size should indeed be usable (gnome-shell topbar is eating a bit of screen estate).
Comment 9 Zeeshan Ali 2014-03-26 00:15:12 UTC
Created attachment 272926 [details] [review]
app-window: Make content stack, homogeneous

This is so that Boxes window doesn't suddenly grow back on its own
after user has put it in a particular size.
Comment 10 Zeeshan Ali 2014-03-26 00:15:19 UTC
Created attachment 272927 [details] [review]
wizard: Reduce vertical margins

This is so that main window can fit in 625x750px. However we still won't
fit on many small screens out there, where height is 768px and
gnome-shell's topbar already takes 24px.
Comment 11 Zeeshan Ali 2014-03-26 00:15:22 UTC
Created attachment 272928 [details] [review]
wizard-source: Show 4 medias on short screens

On small screens, where height is typically less than 800, lets keep
number of visible medias limited to 4 (rather than 5). This is so that
main window can fit in 625x678px.
Comment 12 Zeeshan Ali 2014-03-26 00:16:49 UTC
These patches fix both issues we are tracking here.
Comment 13 Christophe Fergeau 2014-03-26 10:41:06 UTC
Much better on my laptop screen indeed, though the wizard could help some left/right margins, see screenshots
Comment 14 Christophe Fergeau 2014-03-26 10:42:43 UTC
Created attachment 272979 [details]
screenshot #1

A margin to the right of the text look better
Comment 15 Christophe Fergeau 2014-03-26 10:44:27 UTC
Created attachment 272980 [details]
screenshot #2

Some left/right margins for the top text would look better on this one.
Comment 16 Zeeshan Ali 2014-03-26 13:22:05 UTC
Created attachment 272989 [details] [review]
app-window: Make stacks, homogeneous

v2: Make both stacks, homogeneous.
Comment 17 Zeeshan Ali 2014-03-26 13:22:29 UTC
Created attachment 272990 [details] [review]
wizard: Put some margin on the left & right

So wizard doesn't look horrible on small dimensions.
Comment 18 Zeeshan Ali 2014-03-26 23:44:47 UTC
Attachment 272927 [details] pushed as fcf5a3a - wizard: Reduce vertical margins
Attachment 272928 [details] pushed as 57e6ddd - wizard-source: Show 4 medias on short screens
Attachment 272989 [details] pushed as 3c50589 - app-window: Make stacks, homogeneous
Attachment 272990 [details] pushed as b957be5 - wizard: Put some margin on the left & right