After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 747183 - documents: Use the trash
documents: Use the trash
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-04-01 14:31 UTC by Bastien Nocera
Modified: 2015-04-01 23:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
documents: Use the trash (1.18 KB, patch)
2015-04-01 14:31 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2015-04-01 14:31:32 UTC
.
Comment 1 Bastien Nocera 2015-04-01 14:31:36 UTC
Created attachment 300751 [details] [review]
documents: Use the trash

It's there for when the user makes a mistake, but also for when the
software makes one.
Comment 2 Jakub Steiner 2015-04-01 14:34:30 UTC
Bug ate your files. You're angry. I feel for you, I really do. But undo is so much better for fixing an immediate human error. Trash is just a lame workaround.
Comment 3 Debarshi Ray 2015-04-01 19:27:25 UTC
(In reply to Jakub Steiner from comment #2)
> Bug ate your files. You're angry. I feel for you, I really do. But undo is
> so much better for fixing an immediate human error. Trash is just a lame
> workaround.

We are not taking away undo. The question is: what happens when you are beyond that.

Given the target audience of the application (don't expose the filesystem, etc.), how is putting a file in trash different from actually deleting it? Are you worried about not reclaiming disk space?

Also, the way we expose the undo to the user, it is not very clear what is going on. It is not clear that it is based on a timer and that it will be permanently [1] gone in a few seconds.

[1] It is permanent, even if we finally put it in the trash, because you don't have a UI to restore it from the application.
Comment 4 Bastien Nocera 2015-04-01 21:15:55 UTC
(In reply to Jakub Steiner from comment #2)
> Bug ate your files. You're angry. I feel for you, I really do. But undo is
> so much better for fixing an immediate human error. Trash is just a lame
> workaround.

As rishi said, it doesn't take that away, it just puts it in the Trash instead of irrevocably and irreparably deleting it from the filesystem.
Comment 5 Cosimo Cecchi 2015-04-01 23:03:03 UTC
Review of attachment 300751 [details] [review]:

I do think this is right. Effectively, if the user did not click undo, she still will be able to find the file in the trash which makes sense to me. It also matches Nautilus' behavior.
Comment 6 Bastien Nocera 2015-04-01 23:16:23 UTC
Attachment 300751 [details] pushed as a0b4ad8 - documents: Use the trash