After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728588 - The session is lost after switching back a user
The session is lost after switching back a user
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
: 727526 728461 729320 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-04-20 07:29 UTC by Abandoned account
Modified: 2014-05-25 01:41 UTC
See Also:
GNOME target: 3.12
GNOME version: ---


Attachments
transient-display: don't call unmanage from finish (2.44 KB, patch)
2014-05-16 14:07 UTC, Ray Strode [halfline]
committed Details | Review

Description Abandoned account 2014-04-20 07:29:51 UTC
Switching the user, logging off and logging in back as the original user via GDM login screen I can see a new GNOME session is started instead of bringing me back to the session I left when switching users. It seems that the old session is lost.
Comment 1 Ray Strode [halfline] 2014-05-16 14:07:14 UTC
Created attachment 276674 [details] [review]
transient-display: don't call unmanage from finish

GdmTransientDisplay has this code:

        /* we don't restart/remanage transient displays */
        gdm_display_unmanage (display);

But the display factory already makes sure transient displays aren't
restarted. Furthermore, calling unmanage from finish changes the status
of the display to UNMANAGED instead of FINISHED which causes an
assertion to get blown when the display is disposed if the user logouts
out when user switching.

This commit removes the code since it's unnecessary and actively
harmful.

https://bugzilla.gnome.org/show_bug.cgi?id=728488
Comment 2 Ray Strode [halfline] 2014-05-16 15:32:58 UTC
*** Bug 727526 has been marked as a duplicate of this bug. ***
Comment 3 Ray Strode [halfline] 2014-05-16 18:07:45 UTC
*** Bug 728461 has been marked as a duplicate of this bug. ***
Comment 4 Ray Strode [halfline] 2014-05-16 18:07:54 UTC
*** Bug 729320 has been marked as a duplicate of this bug. ***
Comment 5 Luis Henrique Mello 2014-05-21 04:45:35 UTC
I think this is pretty bad... could it be pushed to 3.12.x?
Comment 6 Ray Strode [halfline] 2014-05-21 10:16:44 UTC
I did a release with this fix for 3.12
Comment 7 Luis Henrique Mello 2014-05-25 01:41:26 UTC
(In reply to comment #6)
> I did a release with this fix for 3.12

You mean gdm 3.12.2 ? Just upgraded it on Arch and the problem persists... I checked the code and those lines:

        /* we don't restart/remanage transient displays */
        gdm_display_unmanage (display);

Were indeed removed but... the problem persists :(