After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728480 - List View in Main Window: title should center vertically
List View in Main Window: title should center vertically
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: UI
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
: 762127 (view as bug list)
Depends on: 792665
Blocks:
 
 
Reported: 2014-04-18 07:10 UTC by Chunyang Xu
Modified: 2018-02-05 21:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Title isn't centered in list view (108.27 KB, image/png)
2014-04-18 07:12 UTC, Chunyang Xu
  Details
libgd: New version fixes list view (778 bytes, patch)
2018-02-01 20:07 UTC, Isaque Galdino
rejected Details | Review
libgd: New version fixes list view alignment (785 bytes, patch)
2018-02-05 20:57 UTC, Isaque Galdino
committed Details | Review

Description Chunyang Xu 2014-04-18 07:10:44 UTC
Currently, the notes' or notebook's title is at the top of each item in list view, but 'type' 'where' and 'date' are centered vertically.
Comment 1 Chunyang Xu 2014-04-18 07:12:15 UTC
Created attachment 274643 [details]
Title isn't centered in list view
Comment 2 Chunyang Xu 2014-04-18 13:25:02 UTC
As far as I know bijiben's list view is from libgd directly so a "two line renderer" is used to hold the title of Notes and Notebooks, although the title only uses one line.

bijiben/libgd/libgd/gd-main-list-view.c line 123:

 cell = gd_two_lines_renderer_new ();
  g_object_set (cell,
                "xalign", 0.0,
                "wrap-mode", PANGO_WRAP_WORD_CHAR,
                "xpad", 12,
                "text-lines", 2,
                NULL);
Comment 3 Pierre-Yves Luyten 2014-04-18 19:26:53 UTC
You might update libgd git submodule to check if the bug still applies, some work was done on gd_two_lines_renderer

If this does not fix it, gnome-document might have the same bug, too. Since I borrowed its code.
https://git.gnome.org/browse/gnome-documents/tree/src/view.js#n263

In such case we need to propose a patch for libgd
Comment 4 Chunyang Xu 2014-04-19 02:27:10 UTC
The problem still exists after I update the libgd submodule.

Yes, gd_two_lines_renderer() does do some work. gnome-documents needs gd_two_lines_renderer() to render two lines,  since their documents have both title and author.

I think we can leave out gd_two_lines_renderer() and use gtk_cell_renderer_text_new() to write a new one. But gd-main-list-view.c is not part of bijiben, I don't know deal with this.
Comment 5 Allan Day 2014-11-11 15:16:41 UTC
There's a related bug against GNOME Documents - https://bugzilla.gnome.org/show_bug.cgi?id=723843

Seems like the fix would be the same.
Comment 6 Isaque Galdino 2018-01-19 14:39:02 UTC
*** Bug 762127 has been marked as a duplicate of this bug. ***
Comment 7 Isaque Galdino 2018-02-01 20:07:17 UTC
Created attachment 367773 [details] [review]
libgd: New version fixes list view

Bijiben has their notes' titles decentralized in list view due to an
issue in libgd.

This commit changes Bijiben code to use a newer libgd commit which
addresses that issue.
Comment 8 Mohammed Sadiq 2018-02-02 01:25:54 UTC
Review of attachment 367773 [details] [review]:

lgtm. This commit fixes the issue. Please commit after the suggested changes:

> libgd: New version fixes list view
May be you can simply say something like: Update libgd, or libgd: Update to latest commit (or so).

> ... decentralized ...
This seems to have a different meaning. may be you can simply say "not centered" or so.

Sorry for the nitpicks. Thanks for the patch.
Comment 9 Isaque Galdino 2018-02-05 20:57:26 UTC
Created attachment 367931 [details] [review]
libgd: New version fixes list view alignment

Bijiben has their notes' titles misaligned in list view due to an issue
in libgd.

This commit changes Bijiben code to use a newer libgd commit which
addresses that issue.
Comment 10 Isaque Galdino 2018-02-05 20:58:41 UTC
Review of attachment 367773 [details] [review]:

I'm not sure why it didn't mark obsolete.
Comment 11 Isaque Galdino 2018-02-05 21:01:55 UTC
Review of attachment 367931 [details] [review]:

>> libgd: New version fixes list view
>May be you can simply say something like: Update libgd, or libgd: Update to latest commit (or so).
My idea is to make sure what this update is about.

>> ... decentralized ...
>This seems to have a different meaning. may be you can simply say "not centered" or so.
Fixed that, thanks for noticing (Portuguese and English got mixed).

>Sorry for the nitpicks. Thanks for the patch.
I really like your comments. It improves the code/documentation quality. Thank you!