After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727267 - Can't open contents and bookmarks dialog
Can't open contents and bookmarks dialog
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.12.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
ready
: 726068 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-03-28 19:35 UTC by Miha
Modified: 2014-03-31 17:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
places: Use GtkStack, not GtkContainer API to add the pages (804 bytes, patch)
2014-03-31 11:36 UTC, Debarshi Ray 		committed Details | Review

Description Miha 2014-03-28 19:35:11 UTC 
With the latest Gnome Documents I can't open contents and bookmarks dialog anymore. Clicking on button in navigation bar that should open the contents dialog has no effect. Clicking the bookmarks button only toggles its selection state, but does nothing else.
Comment 1 Miha 2014-03-28 20:06:10 UTC 
When I click on the button that should open the contents dialog, the following is output to the terminal:

(gnome-documents:4580): Gjs-WARNING **: JS ERROR: TypeError: GjsPrivate.gtk_container_child_set_property is not a function
_init/Gtk.Container.prototype.child_set_property@resource:///org/gnome/gjs/modules/overrides/Gtk.js:11
PlacesDialog<._addPage@/opt/gnome/share/gnome-documents/js/places.js:115
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
PlacesDialog<._createWindow@/opt/gnome/share/gnome-documents/js/places.js:72
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
PlacesDialog<._init@/opt/gnome/share/gnome-documents/js/places.js:41
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
_Base.prototype._construct@resource:///org/gnome/gjs/modules/lang.js:110
Class.prototype._construct/newClass@resource:///org/gnome/gjs/modules/lang.js:204
PreviewView<._showPlaces@/opt/gnome/share/gnome-documents/js/preview.js:207
wrapper@resource:///org/gnome/gjs/modules/lang.js:169
start@/opt/gnome/share/gnome-documents/js/main.js:29
@<command line>:1



When I click on button that should open bookmarks dialog, nothing is output to the terminal.
Comment 2 Allan Day 2014-03-29 16:18:56 UTC 
*** Bug 726068 has been marked as a duplicate of this bug. ***
Comment 3 Debarshi Ray 2014-03-31 11:36:15 UTC 
Created attachment 273330 [details] [review]
places: Use GtkStack, not GtkContainer API to add the pages

I have no idea why this broke in the first place, but this looks like a better way to do the same thing anyway. I remember testing this when working on bug 726343 so something broke relatively recently. Going back to gtk+-3.11.8 has not helped.
Comment 4 Debarshi Ray 2014-03-31 13:22:22 UTC 
Maybe because of bug 721838 ? I don't know.
Comment 5 Debarshi Ray 2014-03-31 13:28:58 UTC 
Either way, this is definitely a regression. I can reproduce it in a Continuous image that I grabbed on 24th March.
Comment 6 Cosimo Cecchi 2014-03-31 16:32:07 UTC 
I think this is happening because after bug 721838, gjs will install the GTK override even in case it's not compiled with --enable-gtk=yes. I'll open a follow-up bug against gjs for that.
Comment 7 Cosimo Cecchi 2014-03-31 16:33:58 UTC 
Review of attachment 273330 [details] [review]:

This looks OK in any case.
Comment 8 Debarshi Ray 2014-03-31 17:06:08 UTC 
Comment on attachment 273330 [details] [review]
places: Use GtkStack, not GtkContainer API to add the pages

Thanks for the review!